[microsoft_sqlserver] add new field buffer_cache_hit_ratio_pct - #18874
Merged
Conversation
Contributor
Vale Linting ResultsSummary: 4 warnings, 1 suggestion found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/microsoft_sqlserver/docs/README.md | 491 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/microsoft_sqlserver/docs/README.md | 491 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/microsoft_sqlserver/docs/README.md | 492 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/microsoft_sqlserver/docs/README.md | 493 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
💡 Suggestions (1)
| File | Line | Rule | Message |
|---|---|---|---|
| packages/microsoft_sqlserver/docs/README.md | 501 | Elastic.WordChoice | Consider using 'select, press, visits' instead of 'hit', unless the term is in the UI. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
Contributor
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
audit |
2386.63 | 1893.94 | -492.69 (-20.64%) | 💔 |
To see the full report comment with /test benchmark fullreport
muthu-mps
reviewed
May 8, 2026
| changes: | ||
| - description: Add `mssql.metrics.buffer_cache_hit_ratio_pct` field to the `performance` data stream | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/1 |
Contributor
There was a problem hiding this comment.
Fix PR link,
Suggested change
| link: https://github.com/elastic/integrations/pull/1 | |
| link: https://github.com/elastic/integrations/pull/18874 |
Contributor
|
@jakubgalecki0 - Can we update the latest dashboard image? |
Contributor
Author
|
@muthu-mps updated |
jakubgalecki0
marked this pull request as ready for review
May 8, 2026 07:18
💚 Build Succeeded
History
|
Contributor
|
Package microsoft_sqlserver - 2.17.0 containing this change is available at https://epr.elastic.co/package/microsoft_sqlserver/2.17.0/ |
andrewkroh
added
dashboard
herrBez
pushed a commit
to herrBez/integrations
that referenced
this pull request
Jun 1, 2026
…ic#18874) * [microsoft_sqlserver] add new field buffer_cache_hit_ratio_pct * add new panel * update screenshot and pr link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Introduce new
buffer_cache_hit_ratio_pctthat calculates buffer hit cache ratio by calculatingBuffer cache hit ratio / Buffer cache hit ratio base.Tested on kibana versions:
8.19.0,9.2.1,9.4.0Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots