Fixes known devices values absent in Sophos policy - #1888
Conversation
* YAML values entered into 'Known Devices' (known_devices) variable are absent in policy when assigning Sophos integration to policy. * Embeds yaml value as an object instead of iterating over it. Closes elastic#1071
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
P1llus
left a comment
There was a problem hiding this comment.
LGTM, but we should test if this actually works as well. Would you mind adding an example config in to the _dev/system folder for the xg datastream?
There should be a format like this there already:
data_stream:
vars:
paths:
- "{{SERVICE_LOGS_DIR}}/sophos-xg*.log"
And under vars you can add your known_devices object you can add maybe 1-2 known_devices?
You can use the serial number: 1234567890123456 and S4000806149EE49 and 2 random example hostnames.
Example system test with variables:
https://github.com/elastic/integrations/blob/master/packages/microsoft_dhcp/data_stream/log/_dev/test/system/test-default-config.yml
* Add known_devices to system test variables
* Add known_devices to system test variables
…3r/integrations into fix/sophos-xg-known-devices-issue
|
@P1llus Thanks. I have added |
|
Looks good @r00tu53r , though I would have expected the output of the system test to also have become updated. It should update the sample_event.json in the package |
|
Thanks again @P1llus I've added the generated sample event file. I see the known devices entry in there. |
|
You need to run |
* YAML values entered into 'Known Devices' (known_devices) variable are absent in policy when assigning Sophos integration to policy. * Embed yaml value as an object instead of iterating over it. * Update system tests for sophos xg - Add known_devices to system test variables * Generate sample event with known_devices entries * Update README.md Closes elastic#1071
What does this PR do?
Fixes known devices values absent in Sophos policy
are absent in policy when assigning Sophos integration to policy.
Closes #1071
Checklist
changelog.ymlfile.How to test this PR locally
Related issues