[azure_gateway_otel] Azure Application Gateway Logs OpenTelemetry Assets - #19010
Conversation
Vale Linting ResultsSummary: 1 warning, 4 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/azure_gateway_otel/docs/README.md | 27 | Elastic.DirectionalLanguage | Don't use directional language. Use 'in the preceding section' instead of 'listed above'. |
💡 Suggestions (4)
| File | Line | Rule | Message |
|---|---|---|---|
| packages/azure_gateway_otel/docs/README.md | 11 | Elastic.WordChoice | Consider using 'efficiently' instead of 'simply', unless the term is in the UI. |
| packages/azure_gateway_otel/docs/README.md | 21 | Elastic.Semicolons | Use semicolons judiciously. |
| packages/azure_gateway_otel/docs/README.md | 23 | Elastic.Semicolons | Use semicolons judiciously. |
| packages/azure_gateway_otel/docs/README.md | 35 | Elastic.Semicolons | Use semicolons judiciously. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
This comment has been minimized.
This comment has been minimized.
TL;DRBuildkite failed in Remediation
Investigation detailsRoot Cause
Relevant evidence in repo state:
Evidence
Verification
Follow-upAfter adding the CODEOWNERS entry, if the check still fails, verify there are no trailing spaces or pattern typos in the new CODEOWNERS line. Note 🔒 Integrity filter blocked 5 itemsThe following items were blocked because they don't meet the GitHub integrity level.
To allow these resources, lower tools:
github:
min-integrity: approved # merged | approved | unapproved | noneWhat is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
/test |
There was a problem hiding this comment.
Pull request overview
Introduces a new Elastic content package (azure_gateway_otel) that ships Kibana dashboards and supporting assets for analyzing Azure Application Gateway logs encoded as OpenTelemetry (EDOT / azureencodingextension), targeting the logs-azure.application_gateway.otel-* data stream.
Changes:
- Adds the new
azure_gateway_otelpackage with manifest, license, changelog, docs, images, and logo assets. - Ships three Kibana dashboards (Overview, WAF, Backend Health) as saved-object JSON.
- Adds
_dev/sharedYAML dashboard sources for authoring/maintenance and updates CODEOWNERS for the new package.
Reviewed changes
Copilot reviewed 11 out of 15 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/azure_gateway_otel/manifest.yml | Declares the new content package, version constraints, discovery dataset, screenshots/icons, and owner. |
| packages/azure_gateway_otel/LICENSE.txt | Adds Elastic License 2.0 for the new package. |
| packages/azure_gateway_otel/changelog.yml | Adds initial changelog entry for v0.1.0. |
| packages/azure_gateway_otel/docs/README.md | Documents prerequisites and what the dashboards expect/cover. |
| packages/azure_gateway_otel/kibana/dashboard/azure_gateway_otel-overview.json | Overview dashboard saved object (ES |
| packages/azure_gateway_otel/kibana/dashboard/azure_gateway_otel-waf.json | WAF dashboard saved object (ES |
| packages/azure_gateway_otel/kibana/dashboard/azure_gateway_otel-backend-health.json | Backend Health dashboard saved object (ES |
| packages/azure_gateway_otel/_dev/shared/azure_gateway_otel-overview.yaml | Dashboard-as-source YAML for Overview (used to generate/maintain JSON). |
| packages/azure_gateway_otel/_dev/shared/azure_gateway_otel-waf.yaml | Dashboard-as-source YAML for WAF. |
| packages/azure_gateway_otel/_dev/shared/azure_gateway_otel-backend-health.yaml | Dashboard-as-source YAML for Backend Health. |
| packages/azure_gateway_otel/img/* | Adds screenshots and the package logo referenced by the manifest. |
| .github/CODEOWNERS | Adds ownership for /packages/azure_gateway_otel. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zmoog
left a comment
There was a problem hiding this comment.
LGTM! Just left a couple of nitpicks, feel free to merge whenever.
💚 Build Succeeded
History
|
|
Are we planning to add Assets(SLOs and Alerts) in a separate PR? |
muthu-mps
left a comment
There was a problem hiding this comment.
Left a comment on assets, Change looks good to me otherwise!
|
Thanks for the review
If needed yes, it can be planned. The scope for this one was dashboards |
|
@lalit-satapathy ok to merge? needs your approval |
|
@lalit-satapathy could we have someone from your team giving the green light and merging the PR, as it seems ready ? |
lalit-satapathy
left a comment
There was a problem hiding this comment.
code owner approval
|
Package azure_gateway_otel - 0.1.0 containing this change is available at https://epr.elastic.co/package/azure_gateway_otel/0.1.0/ |
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues
Screenshots
Overview
WAF
Backend health