Skip to content

multiple: update transform mapping - #19055

Closed
mmahacek wants to merge 5 commits into
mainfrom
mm/365defender
Closed

multiple: update transform mapping#19055
mmahacek wants to merge 5 commits into
mainfrom
mm/365defender

Conversation

@mmahacek

Copy link
Copy Markdown
Contributor

{m365_defender, aws, aws_securityhub, google_scc, microsoft_defender_cloud, microsoft_defender_endpoint, prisma_cloud, qualys_vmdr, rapid7_inishgtvm, teneable_io, wiz} Addresses config not addressed by #14809

Proposed commit message

{m365_defender, aws, aws_securityhub, google_scc, microsoft_defender_cloud, microsoft_defender_endpoint, prisma_cloud, qualys_vmdr, rapid7_inishgtvm, teneable_io, wiz} Addresses transform mapping not addressed by #14809

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Verify component template for the transforms mention in the PR have data_stream.namespace properly mapped as keyword

Related issues

Screenshots

n/a

{m365_defender, aws, aws_securityhub, google_scc, microsoft_defender_cloud, microsoft_defender_endpoint, prisma_cloud, qualys_vmdr, rapid7_inishgtvm, teneable_io, wiz}
Addresses config not addressed by #14809
@mmahacek mmahacek self-assigned this May 18, 2026
@mmahacek mmahacek added bug Something isn't working, use only for issues Integration:aws AWS Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Integration:m365_defender Microsoft Defender XDR Integration:tenable_io Tenable Vulnerability Management Integration:google_scc Google Security Command Center Integration:wiz Wiz Integration:qualys_vmdr Qualys VMDR Integration:prisma_cloud Palo Alto Prisma Cloud Integration:rapid7_insightvm Rapid7 InsightVM Integration:microsoft_defender_cloud Microsoft Defender for Cloud Integration:aws_securityhub AWS Security Hub labels May 18, 2026
@mmahacek
mmahacek marked this pull request as ready for review May 18, 2026 20:12
@mmahacek
mmahacek requested review from a team as code owners May 18, 2026 20:12
@mmahacek
mmahacek enabled auto-merge (squash) May 18, 2026 20:13
@andrewkroh andrewkroh added Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] labels May 19, 2026
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the wrong place to fix this. If it's needed (it is), we should make it possible for a type: constant_keyword to be redefined as a type: keyword. This would be a change in github.com/elastic/elastic-package in the allow list in allowedTypeOverride.

Note that the changes here are bug-fixes (ref) and so should bump patch.

cc @jsoriano

Comment thread packages/aws/changelog.yml Outdated
Comment thread packages/aws/manifest.yml Outdated
Comment thread packages/aws_securityhub/changelog.yml Outdated
Comment thread packages/aws_securityhub/manifest.yml Outdated
Comment thread packages/google_scc/changelog.yml Outdated
Comment thread packages/rapid7_insightvm/manifest.yml Outdated
Comment thread packages/tenable_io/changelog.yml Outdated
Comment thread packages/tenable_io/manifest.yml Outdated
Comment thread packages/wiz/changelog.yml Outdated
Comment thread packages/wiz/manifest.yml Outdated
Co-authored-by: mmahacek <mark@mahacek.net>
@mmahacek

Copy link
Copy Markdown
Contributor Author

@efd6 Thanks for the feedback. It does look like the allowedTypeOverride would benefit from also having {"constant_keyword", "keyword"} defined so that the type could be overridden either direction. I've raised elastic/elastic-package#3583 regarding this.

I updated this PR to bump the versions down from minor to patch, since these packages would need to be rebuilt to get the correct mapping applied after updating the elastic-package anyway.

@mmahacek
mmahacek requested a review from a team as a code owner May 20, 2026 21:49
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @mmahacek

@efd6

efd6 commented May 21, 2026

Copy link
Copy Markdown
Contributor

@mmahacek The elastic-package issue appears to be aligned with ecosystem, so I'd suggest that you send that change. It won't be available for a while, so we should also go ahead with this as an interim fix, but I'd like to see the documentation for the fields defined in ECS be copied over to the local definitions here so that there is not a documentation regression. Then the future follow up would be to revert to the external: ecs while retaining the type new type specification.

@mmahacek

Copy link
Copy Markdown
Contributor Author

@efd6 I'm not on the dev team, and not fluent in Go, so I'm not going to submit any code changes for the elastic-package repo. I've got a issue reported there for someone on that team to pick up.

It also looks like my permissions on this repo have been updated, so I no longer have push access to my branch. I either need someone to update the AWS version since there's a conflict with another patch that has been pushed, or I need to cancel this PR and re-submit from a fork.

@efd6

efd6 commented May 27, 2026

Copy link
Copy Markdown
Contributor
auto-merge was automatically disabled May 28, 2026 07:44

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:aws_securityhub AWS Security Hub Integration:aws AWS Integration:google_scc Google Security Command Center Integration:m365_defender Microsoft Defender XDR Integration:microsoft_defender_cloud Microsoft Defender for Cloud Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Integration:prisma_cloud Palo Alto Prisma Cloud Integration:qualys_vmdr Qualys VMDR Integration:rapid7_insightvm Rapid7 InsightVM Integration:tenable_io Tenable Vulnerability Management Integration:wiz Wiz Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants