Skip to content

aws: restore stable endInclusive bound to findings filter for inspector data stream - #19144

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:s7155-aws-inspector2
Jun 4, 2026
Merged

aws: restore stable endInclusive bound to findings filter for inspector data stream#19144
efd6 merged 1 commit into
elastic:mainfrom
efd6:s7155-aws-inspector2

Conversation

@efd6

@efd6 efd6 commented May 21, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

aws: restore stable endInclusive bound to findings filter for inspector data stream

The previous fix (cd8d67e) removed endInclusive entirely from the
Inspector lastObservedAt filter to prevent nextToken invalidation
caused by (now) re-evaluation during pagination. However, Inspector
may enforce the same oneOf schema constraint as Security Hub, which
rejects filters missing the upper bound.

Use a static far-future epoch value (2032-01-01T00:00:00Z) instead.
Inspector validates that dates fall within [1970-01-01, 2033-01-01),
likely due to a 32-bit epoch representation, so the value must stay
below that ceiling. The static value never changes between pagination
pages, avoiding the original nextToken invalidation.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this May 21, 2026
@efd6 efd6 added Integration:aws AWS bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels May 21, 2026
@efd6
efd6 force-pushed the s7155-aws-inspector2 branch from 66880dd to b177f3c Compare May 21, 2026 20:41
@efd6

efd6 commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

/test

@efd6
efd6 force-pushed the s7155-aws-inspector2 branch from b177f3c to 1ff20a7 Compare May 24, 2026 21:12
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented May 24, 2026

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6
efd6 marked this pull request as ready for review May 24, 2026 23:29
@efd6
efd6 requested review from a team as code owners May 24, 2026 23:29
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix LGTM (merge conflicts needs to be addressed)

…or data stream

The previous fix (cd8d67e) removed endInclusive entirely from the
Inspector lastObservedAt filter to prevent nextToken invalidation
caused by (now) re-evaluation during pagination. However, Inspector
may enforce the same oneOf schema constraint as Security Hub, which
rejects filters missing the upper bound.

Use a static far-future epoch value (2032-01-01T00:00:00Z) instead.
Inspector validates that dates fall within [1970-01-01, 2033-01-01),
likely due to a 32-bit epoch representation, so the value must stay
below that ceiling. The static value never changes between pagination
pages, avoiding the original nextToken invalidation.
@efd6
efd6 force-pushed the s7155-aws-inspector2 branch from 1ff20a7 to 55fa3ab Compare June 4, 2026 20:46
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @efd6

@efd6
efd6 merged commit b001942 into elastic:main Jun 4, 2026
9 checks passed
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package aws - 6.19.2 containing this change is available at https://epr.elastic.co/package/aws/6.19.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:aws AWS Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants