[QNAP NAS]: grok fails on Users field with asterisks in user.name parsing - #19177
Merged
vinit-chauhan merged 2 commits intoMay 28, 2026
Conversation
…isks; relax user.name capture to allow “*” (masked usernames and AD machine accounts)
vinit-chauhan
changed the title
vinit-chauhan
added
Integration:qnap_nas
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
Contributor
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
log |
2624.67 | 1736.11 | -888.56 (-33.85%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
|
Contributor
|
Package qnap_nas - 1.25.4 containing this change is available at https://epr.elastic.co/package/qnap_nas/1.25.4/ |
herrBez
pushed a commit
to herrBez/integrations
that referenced
this pull request
Jun 1, 2026
…sing (elastic#19177) * fix: elastic#18841 — [QNAP NAS]: grok fails on Users field with asterisks; relax user.name capture to allow “*” (masked usernames and AD machine accounts) * Update changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
WHAT: Changed
%{USER:user.name}to%{DATA:user.name}in theSHAREDgrok pattern definition inside the QNAP NAS ingest pipeline (default.yml, line 69). The built-inUSERgrok pattern matches only[a-zA-Z0-9._-]+, which excludes the asterisk character (*).WHY: QNAP NAS logs can contain asterisks in the
Usersfield in two real-world scenarios: Active Directory machine account names (e.g.,DOMAIN\PC-TEST-0001*) and obfuscated/masked usernames (e.g.,**test*ldap***). Any such log line caused the grok processor to fail entirely, dropping the event. Switching to%{DATA}captures any character sequence up to the next delimiter, preserving all surrounding pattern structure while correctly handling these username formats.Checklist
changelog.ymlfile.guidelines.
Author's Checklist
TESTDOMAIN\PC-TEST-0001*and masked username**test*ldap***testhost-smb-abc123**lower*test**.w.n) are included in expected outputHow to test this PR locally
Verify that all existing fixtures still pass and the two new fixtures parse user.name (and user.domain where applicable) correctly.
Related issues
Screenshots
N/A — pipeline-only change, no UI or dashboard impact.