Skip to content

Change page_size and batch_size manifest variable type from text to integer - part 1 - #19249

Merged
kcreddy merged 1 commit into
elastic:mainfrom
kcreddy:fix-batch-page-sizes-type-1
May 29, 2026
Merged

Change page_size and batch_size manifest variable type from text to integer - part 1#19249
kcreddy merged 1 commit into
elastic:mainfrom
kcreddy:fix-batch-page-sizes-type-1

Conversation

@kcreddy

@kcreddy kcreddy commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

Change page_size and batch_size manifest variable type from text to integer - part 1

Several integrations declare page_size or batch_size manifest variables
with type: text when the value is always a positive integer. Fleet
performs no numeric validation on text fields, so a user can set these
to arbitrary strings. Changing to type: integer ensures Fleet rejects
non-numeric input.

Relates https://github.com/elastic/integrations/issues/19248

[git-generate]
for pkg in abnormal_security armis authentik aws_securityhub cyberark_epm; do
  find "packages/$pkg/" -type f -name manifest.yml \
    -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} +
done
for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do
  (
    cd "$pkg"
    elastic-package changelog add \
      --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \
      --type bugfix --next patch \
      --link "https://github.com/elastic/integrations/pull/19249"
  )
done

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Related issues
@kcreddy
Change page_size and batch_size manifest variable type from text to i…
044a9da 
…nteger - part 1

Several integrations declare page_size or batch_size manifest variables
with type: text when the value is always a positive integer. Fleet
performs no numeric validation on text fields, so a user can set these
to arbitrary strings. Changing to type: integer ensures Fleet rejects
non-numeric input.

Relates elastic#19248

[git-generate]
for pkg in abnormal_security armis authentik aws_securityhub cyberark_epm; do
  find "packages/$pkg/" -type f -name manifest.yml \
    -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} +
done
for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do
  (
    cd "$pkg"
    elastic-package changelog add \
      --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \
      --type bugfix --next patch \
      --link "elastic#19249"
  )
done
@kcreddy
kcreddy force-pushed the fix-batch-page-sizes-type-1 branch from ab0222a to 044a9da Compare May 27, 2026 21:09
@elasticmachine

elasticmachine commented May 27, 2026

Copy link
Copy Markdown

💚 Build Succeeded
@kcreddy kcreddy self-assigned this May 28, 2026
@kcreddy kcreddy added Integration:abnormal_security Abnormal AI Integration:authentik authentik Integration:cyberark_epm CyberArk EPM Integration:armis Armis Integration:aws_securityhub AWS Security Hub bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels May 28, 2026
@kcreddy
kcreddy marked this pull request as ready for review May 28, 2026 08:13
@kcreddy
kcreddy requested review from a team as code owners May 28, 2026 08:13
@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented May 28, 2026

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@kcreddy
kcreddy merged commit adc4c9e into elastic:main May 29, 2026
8 checks passed
@kcreddy
kcreddy deleted the fix-batch-page-sizes-type-1 branch May 29, 2026 03:11
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Package abnormal_security - 1.14.2 containing this change is available at https://epr.elastic.co/package/abnormal_security/1.14.2/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Package armis - 0.4.2 containing this change is available at https://epr.elastic.co/package/armis/0.4.2/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Package authentik - 1.9.1 containing this change is available at https://epr.elastic.co/package/authentik/1.9.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Package aws_securityhub - 1.0.1 containing this change is available at https://epr.elastic.co/package/aws_securityhub/1.0.1/
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Package cyberark_epm - 1.4.1 containing this change is available at https://epr.elastic.co/package/cyberark_epm/1.4.1/
@kcreddy kcreddy mentioned this pull request May 29, 2026
Closed
herrBez pushed a commit to herrBez/integrations that referenced this pull request Jun 1, 2026
@kcreddy @herrBez
Change page_size and batch_size manifest variable type from text to i…
2846e4c 
…nteger - part 1 (elastic#19249)

Several integrations declare page_size or batch_size manifest variables
with type: text when the value is always a positive integer. Fleet
performs no numeric validation on text fields, so a user can set these
to arbitrary strings. Changing to type: integer ensures Fleet rejects
non-numeric input.

Relates elastic#19248

[git-generate]
for pkg in abnormal_security armis authentik aws_securityhub cyberark_epm; do
  find "packages/$pkg/" -type f -name manifest.yml \
    -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} +
done
for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do
  (
    cd "$pkg"
    elastic-package changelog add \
      --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \
      --type bugfix --next patch \
      --link "elastic#19249"
  )
done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:abnormal_security Abnormal AI Integration:armis Armis Integration:authentik authentik Integration:aws_securityhub AWS Security Hub Integration:cyberark_epm CyberArk EPM Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants

@kcreddy @elasticmachine @efd6