enable agentless for aws metrics - #19339
Conversation
Elastic Docs Style Checker (Vale)Summary: 1 suggestion found 💡 Suggestions (1): Optional style improvements. Apply when helpful.
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
| agentless: | ||
| enabled: true | ||
| organization: observability | ||
| division: engineering | ||
| team: obs-infraobs-integrations |
|
I have tested all the datastreams and they work as expected with one exception.
The CloudWatch publishes S3 storage metrics once per day with a timestamp at This is independent of deployment mode (agentless / managed agent / standalone). I found that ES has merged this PR But it does not seem to be supported in the package spec https://github.com/elastic/package-spec/blob/5b548159e229eadd65402672145fa55a8417caae/spec/integration/data_stream/manifest.spec.yml#L257 @jsoriano Maybe that is something your team could support! I manually changed it in Kibana through a custom pipeline. But that is a manual thing the user needs to do. |
Issue created for that: elastic/package-spec#1179 Thanks for checking it works with |
🚀 Benchmarks reportTo see the full report comment with |
Thank you @jsoriano ! |
|
@zmoog , @agithomas and @andrewkroh |
zmoog
left a comment
There was a problem hiding this comment.
LGTM.
I think the only thing missing now is the "How do I deploy this integration?" section in the data stream docs.
This comment has been minimized.
This comment has been minimized.
TL;DRTwo checks failed due to PR-scoped metadata/docs drift, not runtime code execution: Remediation
Investigation detailsRoot Cause
Evidence
Verification
Follow-up
Note 🔒 Integrity filter blocked 3 itemsThe following items were blocked because they don't meet the GitHub integrity level.
To allow these resources, lower tools:
github:
min-integrity: approved # merged | approved | unapproved | noneWhat is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
This is a new check that we're giving a try to keep the changelog links in sync with the pull requests. In this case , it fails because it has been set a pull request link that it does not match with the pull request opened. link: https://github.com/elastic/integrations/pull/19283It looks like that maybe you wanted to use the issue link instead ? If it is set that issue link in the changleog entry, this check would run successfully too. Currently, this check is just informative and it is not blocking. Updated the message shown in those comments #19379 |
@mrodm That's a very good addition or else such a mistake would have been merged undetected. |
|
✅ All changelog entries have the correct PR link. |
💚 Build Succeeded
History
|
|
Package aws - 6.20.0 containing this change is available at https://epr.elastic.co/package/aws/6.20.0/ |
Proposed commit message
Checklist
changelog.ymlfile.Related issues
Screenshots