Skip to content

[Kafka Connect] Add condition field to Kafka Connect integration - #19354

Open
Alphayeeeet wants to merge 11 commits into
elastic:mainfrom
Alphayeeeet:kafka_connect_add_condition
Open

[Kafka Connect] Add condition field to Kafka Connect integration#19354
Alphayeeeet wants to merge 11 commits into
elastic:mainfrom
Alphayeeeet:kafka_connect_add_condition

Conversation

@Alphayeeeet

Copy link
Copy Markdown
Contributor

Please label as enhancement

This PR adds a condition field to the Kafka Connect integration to allow condition based autodiscovery.

@Alphayeeeet
Alphayeeeet requested a review from a team as a code owner June 3, 2026 09:48
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Reviewers

Buildkite won't run for external contributors automatically; you need to add a comment:

  • /test : will kick off a build in Buildkite.

NOTE: https://github.com/elastic/integrations/blob/main/.buildkite/pull-requests.json contains all those details.

@andrewkroh andrewkroh added Integration:kafka_connect Kafka Connect Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jun 3, 2026
@Alphayeeeet

Copy link
Copy Markdown
Contributor Author

@andrewkroh Could you provide an update, when obs-infraobs team is planning to review this PR? Thanks

Copilot AI lite review requested due to automatic review settings August 18, 2026 15:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Kafka Connect integration package to support condition-based autodiscovery by introducing a user-configurable condition variable and rendering it into the generated Elastic Agent input configuration.

Changes:

  • Add a condition variable to the Kafka Connect package policy input variables.
  • Render condition into each Kafka Connect data stream’s agent stream template when set.
  • Update package version and changelog entries (currently appears to include unrelated/rebased release history).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/kafka_connect/manifest.yml Adds condition var to the jolokia/metrics input and bumps package version.
packages/kafka_connect/data_stream/worker/agent/stream/stream.yml.hbs Emits condition into the worker stream config when provided.
packages/kafka_connect/data_stream/task/agent/stream/stream.yml.hbs Emits condition into the task stream config when provided.
packages/kafka_connect/data_stream/connector/agent/stream/stream.yml.hbs Emits condition into the connector stream config when provided.
packages/kafka_connect/data_stream/client/agent/stream/stream.yml.hbs Emits condition into the client stream config when provided.
packages/kafka_connect/changelog.yml Adds/updates version entries, but references other PRs/changes than the current PR intent.
Suppressed comments (1)

packages/kafka_connect/changelog.yml:10

  • The newly added 0.2.0 changelog entry claims "Allow for setting condition" but links to PR #19354 rather than the current PR. If this PR is the one introducing condition for Kafka Connect, the changelog entry should be attributed to this PR; otherwise, if #19354 is already merged on the base branch, it likely shouldn't be reintroduced in this PR diff (rebase needed).
- version: "0.2.0"
  changes:
    - description: Allow for setting condition
      type: enhancement
      link: https://github.com/elastic/integrations/pull/19354

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/kafka_connect/manifest.yml Outdated
Comment on lines +1 to +3
name: kafka_connect
title: Kafka Connect
version: "0.1.2"
version: "0.2.1"
Comment thread packages/kafka_connect/changelog.yml Outdated
Comment on lines 1 to 5
- version: "0.2.1"
changes:
- description: Add group field to package manifest.
type: enhancement
link: https://github.com/elastic/integrations/pull/20548
Copilot AI review requested due to automatic review settings August 27, 2026 11:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Suppressed comments (2)

packages/kafka_connect/changelog.yml:5

  • The 0.2.1 changelog entry doesn’t mention the main change introduced by this PR (adding a configurable condition field for dynamic input configuration). As written, 0.2.1 looks unrelated to the PR’s purpose, which makes the package release history misleading.
- version: "0.2.1"
  changes:
    - description: Add group field to package manifest.
      type: enhancement
      link: https://github.com/elastic/integrations/pull/20548

packages/kafka_connect/manifest.yml:3

  • The package version is bumped to 0.2.1, but the changelog currently attributes 0.2.1 to an unrelated change and attributes the new condition capability to 0.2.0. Please ensure manifest.yml’s version matches the changelog entry that actually describes the changes introduced by this PR.
version: "0.2.1"
Comment thread packages/kafka_connect/changelog.yml
Copilot AI review requested due to automatic review settings August 27, 2026 13:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 27, 2026 13:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:kafka_connect Kafka Connect Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

3 participants