[Kafka Connect] Add condition field to Kafka Connect integration - #19354
[Kafka Connect] Add condition field to Kafka Connect integration#19354Alphayeeeet wants to merge 11 commits into
Conversation
ReviewersBuildkite won't run for external contributors automatically; you need to add a comment:
NOTE: https://github.com/elastic/integrations/blob/main/.buildkite/pull-requests.json contains all those details. |
|
@andrewkroh Could you provide an update, when obs-infraobs team is planning to review this PR? Thanks |
There was a problem hiding this comment.
Pull request overview
This PR updates the Kafka Connect integration package to support condition-based autodiscovery by introducing a user-configurable condition variable and rendering it into the generated Elastic Agent input configuration.
Changes:
- Add a
conditionvariable to the Kafka Connect package policy input variables. - Render
conditioninto each Kafka Connect data stream’s agent stream template when set. - Update package version and changelog entries (currently appears to include unrelated/rebased release history).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/kafka_connect/manifest.yml | Adds condition var to the jolokia/metrics input and bumps package version. |
| packages/kafka_connect/data_stream/worker/agent/stream/stream.yml.hbs | Emits condition into the worker stream config when provided. |
| packages/kafka_connect/data_stream/task/agent/stream/stream.yml.hbs | Emits condition into the task stream config when provided. |
| packages/kafka_connect/data_stream/connector/agent/stream/stream.yml.hbs | Emits condition into the connector stream config when provided. |
| packages/kafka_connect/data_stream/client/agent/stream/stream.yml.hbs | Emits condition into the client stream config when provided. |
| packages/kafka_connect/changelog.yml | Adds/updates version entries, but references other PRs/changes than the current PR intent. |
Suppressed comments (1)
packages/kafka_connect/changelog.yml:10
- The newly added 0.2.0 changelog entry claims "Allow for setting condition" but links to PR #19354 rather than the current PR. If this PR is the one introducing
conditionfor Kafka Connect, the changelog entry should be attributed to this PR; otherwise, if #19354 is already merged on the base branch, it likely shouldn't be reintroduced in this PR diff (rebase needed).
- version: "0.2.0"
changes:
- description: Allow for setting condition
type: enhancement
link: https://github.com/elastic/integrations/pull/19354
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| name: kafka_connect | ||
| title: Kafka Connect | ||
| version: "0.1.2" | ||
| version: "0.2.1" |
| - version: "0.2.1" | ||
| changes: | ||
| - description: Add group field to package manifest. | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/20548 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Suppressed comments (2)
packages/kafka_connect/changelog.yml:5
- The 0.2.1 changelog entry doesn’t mention the main change introduced by this PR (adding a configurable
conditionfield for dynamic input configuration). As written, 0.2.1 looks unrelated to the PR’s purpose, which makes the package release history misleading.
- version: "0.2.1"
changes:
- description: Add group field to package manifest.
type: enhancement
link: https://github.com/elastic/integrations/pull/20548
packages/kafka_connect/manifest.yml:3
- The package version is bumped to 0.2.1, but the changelog currently attributes 0.2.1 to an unrelated change and attributes the new
conditioncapability to 0.2.0. Please ensuremanifest.yml’s version matches the changelog entry that actually describes the changes introduced by this PR.
version: "0.2.1"
Please label as enhancement
This PR adds a condition field to the Kafka Connect integration to allow condition based autodiscovery.