[cisco_ise] Correct parsing of kv pairs with commas - #19562
Merged
Conversation
Fixed KV pair parsing in 16 Cisco ISE ingest pipelines to handle values containing commas, by adding a look-ahead pattern to determine if the comma is part of the value field or delimiter of the value.
mjwolf
added
Integration:cisco_ise
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
Contributor
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
Contributor
🚀 Benchmarks reportTo see the full report comment with |
andrewkroh
added
the
documentation
Contributor
|
✅ All changelog entries have the correct PR link. |
��� Build Succeeded
History
cc @mjwolf |
mjwolf
enabled auto-merge (squash)
June 18, 2026 19:28
|
👀 I have started reviewing the PR |
Vera Review BotReview completed with no findings. Verdict: APPROVED AI-generated review status. Verify suggestions before applying. |
qcorporation
approved these changes
Jun 19, 2026
Contributor
|
Package cisco_ise - 1.32.7 containing this change is available at https://epr.elastic.co/package/cisco_ise/1.32.7/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Fixed KV pair parsing in 16 Cisco ISE ingest pipelines to handle values containing commas, by adding a positive lookahead pattern to correctly determine the end of the value field.
Checklist
changelog.ymlfile.How to test this PR locally
New pipeline test case has been added which exercises the case where kv value contains a comma.