Skip to content

[salesforce] Re-expose Request Timeout (resource.timeout) for all data streams - #19717

Merged
stefans-elastic merged 2 commits into
elastic:mainfrom
stefans-elastic:salesforce-expose-resource-timeout
Jun 23, 2026
Merged

[salesforce] Re-expose Request Timeout (resource.timeout) for all data streams#19717
stefans-elastic merged 2 commits into
elastic:mainfrom
stefans-elastic:salesforce-expose-resource-timeout

Conversation

@stefans-elastic

Copy link
Copy Markdown
Contributor

Proposed commit message

The Request Timeout setting was dropped in the v0.15.0 revamp (#9629), when
the integration moved from the httpjson input to the dedicated salesforce
Filebeat input. Since then there has been no way to override the input's
default 30s HTTP client timeout, so large EventLogFile downloads (notably
Apex logs) can fail with context deadline exceeded and no available remedy.

This PR re-exposes it as a resource_timeout variable (default 30s, under
Advanced options) for all four data streams (apex, login, logout,
setupaudittrail), wiring it to resource.timeout in each stream template.
The variable is emitted conditionally, so existing policies keep the input's
built-in default and there is no behavior change on upgrade.

The troubleshooting docs are updated to reflect the current error signature,
and the package version is bumped to 1.8.0.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • elastic-package build and elastic-package lint in packages/salesforce.
  • elastic-package test system --data-streams apex (passes with the default 30s, and with an explicit resource_timeout value such as 120s added to the test config).
  • On a live deployment, set Request Timeout (Advanced options) on a data stream and confirm resource.timeout is rendered into the compiled agent policy. Setting it to a very small value (e.g. 1ms) makes the input fail with context deadline exceeded; restoring it (e.g. 30s) recovers the unit — confirming the setting is honored.
…a streams

The Request Timeout setting was dropped in the v0.15.0 revamp (elastic#9629) when
the integration moved from the httpjson input to the dedicated salesforce
Filebeat input. Since then there was no way to override the input's default
30s HTTP client timeout, so large EventLogFile downloads (notably Apex logs)
could fail with "context deadline exceeded" with no available remedy.

Re-expose it as a `resource_timeout` variable (default 30s, in Advanced
options) across all four data streams (apex, login, logout, setupaudittrail),
wiring it to `resource.timeout` in each stream template. Update the
troubleshooting docs to reflect the current error signature and bump the
package version to 1.8.0.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@stefans-elastic
stefans-elastic requested a review from a team as a code owner June 23, 2026 10:44
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@stefans-elastic stefans-elastic added Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Integration:salesforce Salesforce labels Jun 23, 2026
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.

@stefans-elastic
stefans-elastic requested a review from shmsr June 23, 2026 11:03
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

@shmsr shmsr added the enhancement New feature or request label Jun 23, 2026
@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@stefans-elastic
stefans-elastic merged commit 5410fb7 into elastic:main Jun 23, 2026
11 checks passed
@stefans-elastic
stefans-elastic deleted the salesforce-expose-resource-timeout branch June 23, 2026 11:17
@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • 🟠 Waiting for queue conditions
  • ⏳ Enter queue
  • ⏳ Run checks
  • ⏳ Merge
Waiting for
  • -closed [📌 queue requirement]
All conditions
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue rule default]:
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #approved-reviews-by >= 1 [🛡 GitHub repository ruleset rule [org] Require a PR for Renovate]
      • #approved-reviews-by >= 1 [🛡 GitHub repository ruleset rule [org] Require a PR]
      • github-review-decision = APPROVED [🛡 GitHub branch protection]
      • any of [🛡 GitHub branch protection]:
        • check-success = CLA
        • check-neutral = CLA
        • check-skipped = CLA
      • any of [🛡 GitHub branch protection]:
        • check-success = buildkite/integrations
        • check-neutral = buildkite/integrations
        • check-skipped = buildkite/integrations
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package salesforce - 1.8.0 containing this change is available at https://epr.elastic.co/package/salesforce/1.8.0/

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:salesforce Salesforce Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

4 participants