[trellix_epo_cloud, withsecure_elements] Add Agentless Deployment - #19760
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Elastic Docs Style Checker (Vale)Summary: 3 warnings, 2 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/withsecure_elements/_dev/build/docs/README.md | 61 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/withsecure_elements/_dev/build/docs/README.md | 63 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/withsecure_elements/_dev/build/docs/README.md | 93 | Elastic.DontUse | Don't use 'please'. |
💡 Suggestions (2): Optional style improvements. Apply when helpful.
| File | Line | Rule | Message |
|---|---|---|---|
| packages/withsecure_elements/_dev/build/docs/README.md | 29 | Elastic.WordChoice | Consider using 'deactivate, deselect, hide, turn off' instead of 'disable', unless the term is in the UI. |
| packages/withsecure_elements/_dev/build/docs/README.md | 44 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'Disabled', unless the term is in the UI. |
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.
|
✅ All changelog entries have the correct PR link. |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
👀 I have started reviewing the PR |
| target_field: event.original | ||
| ignore_missing: true | ||
| if: ctx.event?.original == null | ||
| - remove: |
There was a problem hiding this comment.
🟡 MEDIUM data_stream/event/.../default.yml:21
Agentless metadata fields not removed in CEL pipelines
This PR enables Agentless deployment for the package (manifest deployment_modes.agentless.enabled: true). When the Agentless framework runs the CEL input, it injects the metadata fields organization, division, and team into the document root. The three trellix_epo_cloud pipelines (this event pipeline plus device/.../default.yml and group/.../default.yml) do not strip them. organization is defined in ECS as an object (organization.name, organization.id); an injected top-level string value (here organization: security) collides with that mapping and can cause indexing/mapping conflicts, and division/team get indexed as stray non-ECS fields. The CEL/Agentless opening remove (and the error-placeholder terminate) processors documented for CEL inputs are absent here, so enabling Agentless surfaces this gap now rather than hypothetically.
Recommendation:
Add the CEL/Agentless opening processors near the top of each of the three pipelines (event, device, group), before the rename message -> event.original step:
- remove:
field:
- organization
- division
- team
ignore_missing: true
if: ctx.organization instanceof String && ctx.division instanceof String && ctx.team instanceof String
tag: remove_agentless_tags
description: >-
Removes the fields added by Agentless as metadata,
as they can collide with ECS fields.
- terminate:
tag: data_collection_error
if: ctx.error?.message != null && ctx.message == null && ctx.event?.original == null
description: error message set and no data to process.🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills
⚠️ Automated review — verify suggestions before applying.
There was a problem hiding this comment.
This is not required in kibana version 8.19.2 and above. Ref - elastic/kibana#221312
kcreddy
left a comment
There was a problem hiding this comment.
Replace _dev/deploy/doc with _dev/build/docs in the commit message.
LGTM otherwise.
|
Tick the box to add this pull request to the merge queue (same as
|
|
Package trellix_epo_cloud - 1.16.0 containing this change is available at https://epr.elastic.co/package/trellix_epo_cloud/1.16.0/ |
|
Package withsecure_elements - 0.3.0 containing this change is available at https://epr.elastic.co/package/withsecure_elements/0.3.0/ |
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues