[akamai] Add Support for Identity Fields from SIEM Events - #20029
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
|
✅ All changelog entries have the correct PR link. |
| - name: ja4 | ||
| type: keyword | ||
| description: A JA4 TLS client fingerprint value. | ||
|
|
There was a problem hiding this comment.
Severity: 🔵 Low confidence: medium path: packages/akamai/data_stream/siem/fields/fields.yml:114
Blank separator lines in the new identity field block contain trailing whitespace; remove it so elastic-package format/check does not rewrite the file.
Details
The added identity group inserts blank lines that are not empty but contain trailing spaces (after the ja4 and tls_fingerprint_v2 entries). elastic-package format normalizes these away, so committing them as-is can cause a format/lint diff in CI. Purely cosmetic, but it keeps the file from being format-clean.
Recommendation:
Make the separator lines truly empty (no trailing spaces):
- name: identity
type: group
fields:
- name: ja4
type: keyword
description: A JA4 TLS client fingerprint value.
- name: tls_fingerprint_v2
type: keyword
description: A client TLS fingerprint V2 value.
- name: tls_fingerprint_v3
type: keyword
description: A client TLS fingerprint V3 value.🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills
⚠️ Automated review — verify suggestions before applying.
Review summaryIssues found across the latest commits e4e119b — 1 low
🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills
|
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
efd6
left a comment
There was a problem hiding this comment.
I'm wondering why we're not putting the json processor's result directly into akamai.siem directly; this would mean that if the API changes the fields that it provides, we just naturally follow. This is fine, but we'd need to do less work in future if we just followed the API.
|
Tick the box to add this pull request to the merge queue (same as
|
I agree that populating the JSON processor output directly would reduce the maintenance effort, as any new fields introduced by the API would be ingested automatically without requiring additional mapping changes. The trade-off is only that we would have less control over the schema and field mappings. However, I think the reduced maintenance and automatic adoption of new fields outweigh those concerns. |
|
Package akamai - 3.2.0 containing this change is available at https://epr.elastic.co/package/akamai/3.2.0/ |
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related Issues