Skip to content

Add ecs fields in container logs - #2033

Merged
MichaelKatsoulis merged 5 commits into
elastic:masterfrom
MichaelKatsoulis:add_ecs_fields_container_logs
Oct 27, 2021
Merged

Add ecs fields in container logs#2033
MichaelKatsoulis merged 5 commits into
elastic:masterfrom
MichaelKatsoulis:add_ecs_fields_container_logs

Conversation

@MichaelKatsoulis

@MichaelKatsoulis MichaelKatsoulis commented Oct 26, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR adds ecs fields in container_logs data stream of kubernetes integrations.
Without the declaration of those fields the mappings where taking default types which is not optimal in all cases.
An example is the message field which as a default was mapped to keyword instead of text. (https://elastic.slack.com/archives/CJZ9U5G9X/p1635183286042600)

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).
@MichaelKatsoulis MichaelKatsoulis added the Team:Integrations Label for the Integrations team label Oct 26, 2021
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)

@MichaelKatsoulis MichaelKatsoulis added the enhancement New feature or request label Oct 26, 2021
@elasticmachine

elasticmachine commented Oct 26, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-27T10:56:25.850+0000

  • Duration: 31 min 0 sec

  • Commit: 973ed1e

Test stats 🧪

Test Results
Failed 0
Passed 114
Skipped 0
Total 114

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@MichaelKatsoulis

Copy link
Copy Markdown
Contributor Author

/test

@ChrsMark ChrsMark left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, apart of the conflicts :).
Btw will we change the type of the message to text too here or in another PR?

@MichaelKatsoulis

Copy link
Copy Markdown
Contributor Author

lgtm, apart of the conflicts :).
Btw will we change the type of the message to text too here or in another PR?

- external: ecs
   name: message

message is an ecs fields which type is text (https://github.com/elastic/ecs/blob/master/schemas/base.yml#L52)

@ChrsMark ChrsMark left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelKatsoulis
MichaelKatsoulis merged commit 4490aec into elastic:master Oct 27, 2021
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Add ecs fields in container logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Team:Integrations Label for the Integrations team

3 participants