Skip to content

checkpoint: fix parsing of usernames and email addresses - #20517

Merged
taylor-swanson merged 4 commits into
elastic:mainfrom
taylor-swanson:fix/checkpoint-user-parsing
Aug 4, 2026
Merged

checkpoint: fix parsing of usernames and email addresses#20517
taylor-swanson merged 4 commits into
elastic:mainfrom
taylor-swanson:fix/checkpoint-user-parsing

Conversation

@taylor-swanson

@taylor-swanson taylor-swanson commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

Add an additional pattern to the various user name parsing grok processors to handle an additional case where there is just a user name within parentheses.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

cd packages/checkpoint
elastic-package test
@taylor-swanson
checkpoint: fix parsing of usernames and email addressses
a0dc79a 
Add an additional pattern to the various user name parsing grok processors
to handle an additional case where there is just a user name within
parentheses.
@taylor-swanson taylor-swanson self-assigned this Aug 4, 2026
@taylor-swanson taylor-swanson added Integration:checkpoint Check Point bugfix Pull request that fixes a bug issue Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!

The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@taylor-swanson
taylor-swanson marked this pull request as ready for review August 4, 2026 13:27
@taylor-swanson
taylor-swanson requested a review from a team as a code owner August 4, 2026 13:27
@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Aug 4, 2026

Copy link
Copy Markdown

Pinging @elastic/integration-experience (Team:Integration-Experience)
vera-review-bot[bot]
vera-review-bot Bot reviewed Aug 4, 2026
View reviewed changes
Comment thread packages/checkpoint/data_stream/firewall/elasticsearch/ingest_pipeline/default.yml Outdated
@vera-review-bot

vera-review-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

No issues across the latest commits 50109ef.

Review summary

Issues found across earlier commits 8435dab — 1 low
  • 🔵 The new '<full_name> ()' grok pattern uses %{DATA} for the parenthesised capture, so a value with more than one parenthesised group is split at the first ' (' and leaves stray parentheses in the user name (link) (Resolved)

A new commit triggers another review — at most once every 15 minutes. I skip the PR while it's approved or has merge conflicts.

🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.
@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Aug 4, 2026

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @taylor-swanson
@mergify

mergify Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request
@taylor-swanson
taylor-swanson merged commit ded83e5 into elastic:main Aug 4, 2026
9 checks passed
@taylor-swanson
taylor-swanson deleted the fix/checkpoint-user-parsing branch August 4, 2026 17:56
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Package checkpoint - 1.49.1 containing this change is available at https://epr.elastic.co/package/checkpoint/1.49.1/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:checkpoint Check Point Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

2 participants

@taylor-swanson @Niceplace