[Crowdstrike] Mask AWS access_key_id policy variable as secret - #20615
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
| changes: | ||
| - description: Mask AWS access_key_id policy variable as secret for FDR data stream. | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/1 |
There was a problem hiding this comment.
Severity: 🟡 Medium confidence: high path: packages/crowdstrike/changelog.yml:6
The changelog link for 4.7.0 points to elastic/integrations#1, an unrelated PR placeholder; update it to this PR (#20615) so the entry is traceable.
Details
The new 4.7.0 entry links to #1 instead of the PR that introduces the change. elastic-package lint only rejects a non-positive number (pull/0), so this passes validation and would ship a changelog entry pointing at an unrelated 2020-era PR. Every other entry in this file (e.g. 4.6.0 -> pull/20241) links to its own PR.
Recommendation:
Point the link at this PR (20615) so the released changelog is traceable to the change that made access_key_id a secret. Use pull/99999 only as a temporary development placeholder, never a low real PR number.
| link: https://github.com/elastic/integrations/pull/1 | |
| link: https://github.com/elastic/integrations/pull/20615 |
🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills
⚠️ Automated review — verify suggestions before applying.
🚀 Benchmarks reportTo see the full report comment with |
| - name: access_key_id | ||
| type: text | ||
| type: password | ||
| title: Access Key ID | ||
| multi: false | ||
| required: false | ||
| show_user: true | ||
| secret: false | ||
| secret: true |
There was a problem hiding this comment.
Please add a policy test to cover this.
|
🟢 No issues across the latest commits 0b926c6. Review summaryIssues found across earlier commits 7de5ec1 — 1 medium
🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills
|
|
✅ All changelog entries have the correct PR link. |
💚 Build Succeeded
History
|
|
Tick the box to add this pull request to the merge queue (same as
|
|
Package crowdstrike - 4.7.0 containing this change is available at https://epr.elastic.co/package/crowdstrike/4.7.0/ |
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues