[Gitlab] Fix Gitlab Pages duration_ms field - to accept float - #20747
Merged
Conversation
Contributor
ReviewersBuildkite won't run for external contributors automatically; you need to add a comment:
NOTE: https://github.com/elastic/integrations/blob/main/.buildkite/pull-requests.json contains all those details. |
flux-ricky
force-pushed
the
fix/#20675-gitlab-pages
branch
from
August 17, 2026 00:15
72b46b4 to
a20c76d
Compare
Contributor
|
/test |
efd6
reviewed
Aug 17, 2026
flux-ricky
force-pushed
the
fix/#20675-gitlab-pages
branch
from
August 17, 2026 03:09
4b71997 to
7ce4e59
Compare
Contributor
Author
|
Thanks for the quick review, I believe I have addressed the feedback. |
Contributor
|
/test |
Contributor
|
✅ All changelog entries have the correct PR link. |
Contributor
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
api |
3300.33 | 2074.69 | -1225.64 (-37.14%) | 💔 |
audit |
6289.31 | 4484.3 | -1805.01 (-28.7%) | 💔 |
auth |
9433.96 | 4484.3 | -4949.66 (-52.47%) | 💔 |
pages |
12048.19 | 6535.95 | -5512.24 (-45.75%) | 💔 |
production |
3816.79 | 3236.25 | -580.54 (-15.21%) | 💔 |
sidekiq |
3367 | 2857.14 | -509.86 (-15.14%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
History
|
efd6
approved these changes
Aug 17, 2026
Contributor
|
Package gitlab - 3.0.0 containing this change is available at https://epr.elastic.co/package/gitlab/3.0.0/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See Title
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots