Skip to content

Replace logfile input type with filestream type for container logs - #2139

Merged
MichaelKatsoulis merged 4 commits into
elastic:masterfrom
MichaelKatsoulis:use_filestream_for_container_logs_input
Nov 9, 2021
Merged

Replace logfile input type with filestream type for container logs#2139
MichaelKatsoulis merged 4 commits into
elastic:masterfrom
MichaelKatsoulis:use_filestream_for_container_logs_input

Conversation

@MichaelKatsoulis

@MichaelKatsoulis MichaelKatsoulis commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR replaces logfile input type for collecting kubernetes container logs with Filestream type which brings many improvements.

With filestream input CRI parsing is also supported by default with the use of container parser

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

Screenshots

CRI logs parsed as plain text with logfile input
logfile input

CRI logs parsed correctly with filestream input and container parser
filestream input

@MichaelKatsoulis MichaelKatsoulis added enhancement New feature or request Team:Integrations Label for the Integrations team labels Nov 8, 2021
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine

elasticmachine commented Nov 8, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-09T12:43:05.867+0000

  • Duration: 30 min 12 sec

  • Commit: 90086c2

Test stats 🧪

Test Results
Failed 0
Passed 114
Skipped 0
Total 114

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@mtojek
mtojek requested a review from kvch November 8, 2021 15:55
Comment thread packages/kubernetes/changelog.yml Outdated
changes:
- description: Use filestream input for container_logs data stream
type: enhancement
link: https://github.com/elastic/integrations/pull/2041

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: wrong PR?

type: logs
streams:
- input: logfile
- input: filestream

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity: will filestreams be available in 7.16 or just in 8.0?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filestream is available since v7.10 in Filebeat, and since 7.13 in Agent.

symlinks: {{symlinks}}
prospector.scanner.symlinks: {{ symlinks }}
parsers:
- container:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: stream is set to all by default. You can rewrite the config to be shorter like this:

parsers:
- container: ~
@MichaelKatsoulis
MichaelKatsoulis merged commit 2b68de7 into elastic:master Nov 9, 2021
@adammike

adammike commented Nov 9, 2021

Copy link
Copy Markdown

Are these automatically released to install from Kibana when they're merged? or is there a separate release process to wait for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Team:Integrations Label for the Integrations team

6 participants