Skip to content

[Sophos] Update Sophos pipelines for new fields - #2163

Merged
andrewkroh merged 8 commits into
elastic:mainfrom
legoguy1000:2158-sophos
Apr 18, 2022
Merged

[Sophos] Update Sophos pipelines for new fields#2163
andrewkroh merged 8 commits into
elastic:mainfrom
legoguy1000:2158-sophos

Conversation

@legoguy1000

Copy link
Copy Markdown
Contributor

What does this PR do?

Updates Sophos pipelines to support new fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • [ ]

How to test this PR locally

cd integrations/packages/sophos
elastic-package build && elastic-package stack down && elastic-package stack up --version 7.16.0-SNAPSHOT -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test -v

Related issues

Screenshots

@elasticmachine

elasticmachine commented Nov 16, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-18T22:16:32.332+0000

  • Duration: 17 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 17
Skipped 0
Total 17

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@P1llus

P1llus commented Nov 17, 2021

Copy link
Copy Markdown
Member

/test

@P1llus
P1llus requested a review from a team November 17, 2021 17:53
Comment thread packages/sophos/data_stream/xg/elasticsearch/ingest_pipeline/default.yml Outdated
@jamiehynds

Copy link
Copy Markdown

Hey @legoguy1000 - can you advise on the current state of this PR? Do you need anything from us to move towards merging?

@legoguy1000

Copy link
Copy Markdown
Contributor Author

Hey @legoguy1000 - can you advise on the current state of this PR? Do you need anything from us to move towards merging?

I think the big thing was the question/conversation above regarding a couple of fields.

@legoguy1000

Copy link
Copy Markdown
Contributor Author

Also i know this was also brought up in the Beats repo so we can also wait for that to be updated and then just copy the changes?? the parallel effort was also wonky as wanted to keep the changes consistent.

@andrewkroh

Copy link
Copy Markdown
Contributor

I was just commenting about have parallel changes in elastic/beats#29002 (comment).

@legoguy1000

Copy link
Copy Markdown
Contributor Author

Ok, I will rebase and get this updated.

@andrewkroh andrewkroh added Integration:sophos Sophos enhancement New feature or request labels Apr 6, 2022
@andrewkroh

Copy link
Copy Markdown
Contributor

/test

@andrewkroh
andrewkroh requested a review from leehinman April 6, 2022 18:34
Comment thread packages/sophos/data_stream/xg/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/sophos/data_stream/xg/elasticsearch/ingest_pipeline/default.yml Outdated

@andrewkroh andrewkroh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That link you referenced (https://docs.sophos.com/nsg/sophos-firewall/17.5/Help/en-us/webhelp/onlinehelp/nsg/sfos/concepts/LogFields.html) would be great to have in the documentation somewhere.

@legoguy1000

Copy link
Copy Markdown
Contributor Author

@andrewkroh pushed changes

@andrewkroh

Copy link
Copy Markdown
Contributor

/test

Comment thread packages/sophos/data_stream/xg/elasticsearch/ingest_pipeline/firewall.yml Outdated
@andrewkroh
andrewkroh dismissed leehinman’s stale review April 18, 2022 20:15

It has been ~6 months and the pipelien has been updated since.

@andrewkroh

Copy link
Copy Markdown
Contributor

/test

@legoguy1000

Copy link
Copy Markdown
Contributor Author

some weird glitch with the pipeline. I tried to rebuild README and there are no changes so idk.

@andrewkroh

Copy link
Copy Markdown
Contributor

some weird glitch with the pipeline. I tried to rebuild README and there are no changes so idk.

You might have an old version of elastic-package. Try running go install github.com/elastic/elastic-package from the main branch of elastic/integrations to install the version specified in the go.mod file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:sophos Sophos

6 participants