Skip to content

Revert kubernetes namespace field breaking change - #2209

Merged
MichaelKatsoulis merged 3 commits into
elastic:masterfrom
MichaelKatsoulis:revert_kubernetes_namespace_field_update
Nov 24, 2021
Merged

Revert kubernetes namespace field breaking change#2209
MichaelKatsoulis merged 3 commits into
elastic:masterfrom
MichaelKatsoulis:revert_kubernetes_namespace_field_update

Conversation

@MichaelKatsoulis

Copy link
Copy Markdown
Contributor

What does this PR do?

After agreement on #2165 and in continuation of merging elastic/beats#29069
this PR reverts the kubernetes.namespace field update in kubernetes integration as well.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).
@MichaelKatsoulis
MichaelKatsoulis marked this pull request as draft November 23, 2021 11:47
@MichaelKatsoulis

Copy link
Copy Markdown
Contributor Author

After reverting the breaking change I think I should also revert the Kibana constraint to kibana.version: "^7.16.0 || ^8.0.0".

@MichaelKatsoulis
MichaelKatsoulis marked this pull request as ready for review November 23, 2021 11:51

@jsoriano jsoriano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reverted change modified 54 files (#1792), but this one modifies 53, is this expected?

release: ga
conditions:
kibana.version: "^8.0.0"
kibana.version: "^7.16.0 || ^8.0.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-23T11:56:07.903+0000

  • Duration: 33 min 57 sec

  • Commit: 77f71bb

Test stats 🧪

Test Results
Failed 0
Passed 113
Skipped 0
Total 113

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@MichaelKatsoulis
MichaelKatsoulis merged commit 1a89080 into elastic:master Nov 24, 2021
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Revert kubernetes namespace field breaking change

* Update changelog.yml

* Update the kibana constraint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants