Skip to content

[gcp] Update DNS Logs - #2340

Merged
efd6 merged 19 commits into
elastic:mainfrom
legoguy1000:gcp-dns-public-query-logs
Jul 28, 2022
Merged

[gcp] Update DNS Logs#2340
efd6 merged 19 commits into
elastic:mainfrom
legoguy1000:gcp-dns-public-query-logs

Conversation

@legoguy1000

@legoguy1000 legoguy1000 commented Dec 14, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

Enhances the log enrichment/normalization for GCP DNS logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000
legoguy1000 force-pushed the gcp-dns-public-query-logs branch from 66f4d1a to 82368ef Compare December 15, 2021 23:04
@legoguy1000
legoguy1000 marked this pull request as ready for review December 15, 2021 23:04
@elasticmachine

elasticmachine commented Dec 15, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-26T07:23:44.825+0000

  • Duration: 20 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 46
Skipped 0
Total 46

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@legoguy1000

Copy link
Copy Markdown
Contributor Author

@kaiyan-sheng could you run tests for this too?

@kaiyan-sheng

Copy link
Copy Markdown

/test

@legoguy1000
legoguy1000 force-pushed the gcp-dns-public-query-logs branch 3 times, most recently from 5a13d7a to eb0c6ad Compare January 5, 2022 00:24
@legoguy1000

Copy link
Copy Markdown
Contributor Author

OK, i think it should be fixed now.

@legoguy1000
legoguy1000 force-pushed the gcp-dns-public-query-logs branch from eb0c6ad to ae69047 Compare February 4, 2022 03:09
@legoguy1000

Copy link
Copy Markdown
Contributor Author

@kaiyan-sheng can we rerun tests on this?

@kaiyan-sheng

Copy link
Copy Markdown

/test

@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6

efd6 commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

This needs to have the version bumped in manifest.yml.

Comment thread packages/gcp/_dev/deploy/docker/docker-compose.yml Outdated
Comment thread packages/gcp/_dev/build/docs/audit.md Outdated
@legoguy1000

Copy link
Copy Markdown
Contributor Author

fixes pushed.

@legoguy1000
legoguy1000 requested a review from efd6 February 10, 2022 04:33
@legoguy1000
legoguy1000 force-pushed the gcp-dns-public-query-logs branch from 945724f to 58b4098 Compare February 10, 2022 05:20
@efd6

efd6 commented Feb 10, 2022

Copy link
Copy Markdown
Contributor

/test

1 similar comment
@efd6

efd6 commented Feb 10, 2022

Copy link
Copy Markdown
Contributor

/test

@legoguy1000
legoguy1000 force-pushed the gcp-dns-public-query-logs branch from aeeaedf to f544ceb Compare February 11, 2022 21:09
@andrewkroh andrewkroh added the Integration:gcp Google Cloud Platform label Feb 11, 2022
@legoguy1000
legoguy1000 marked this pull request as ready for review July 12, 2022 00:25
@legoguy1000
legoguy1000 requested review from a team as code owners July 12, 2022 00:25
@legoguy1000
legoguy1000 force-pushed the gcp-dns-public-query-logs branch from 864e30b to 84a3eb0 Compare July 12, 2022 00:28
@legoguy1000

Copy link
Copy Markdown
Contributor Author

I rebased and merged the datastreams should be GTG.

@efd6

efd6 commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

elasticmachine commented Jul 12, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 2.988
Classes 100.0% (4/4) 💚 2.988
Methods 94.03% (63/67) 👍 4.315
Lines 95.443% (1173/1229) 👍 4.021
Conditionals 100.0% (0/0) 💚
@legoguy1000 legoguy1000 changed the title [gcp] Add DNS Public Zone Query Logs Jul 12, 2022
@legoguy1000
legoguy1000 requested a review from a team as a code owner July 23, 2022 19:02
@legoguy1000
legoguy1000 force-pushed the gcp-dns-public-query-logs branch from 78f8eee to 3fc2931 Compare July 23, 2022 19:03
@efd6

efd6 commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

/test

Comment thread packages/gcp/data_stream/dns/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/gcp/data_stream/dns/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/gcp/data_stream/dns/elasticsearch/ingest_pipeline/default.yml Outdated
@legoguy1000

Copy link
Copy Markdown
Contributor Author

@efd6 comments addressed

@efd6

efd6 commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

/test

@efd6
efd6 merged commit 26aa970 into elastic:main Jul 28, 2022
@legoguy1000
legoguy1000 deleted the gcp-dns-public-query-logs branch July 28, 2022 02:00
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Add GCP DNS Public Query Logs Dataset

* Update GCP integration

* Fix dataset

* fix tests

* rebuild after rebase

* fixes per comments

* update pipeline

* temp

* merged datastreams.  added additional parsing

* remove extra stuff

* fix accidental deletions

* don't break out into individual policies

* fix manifest

* add DNS to policy templates

* update pipeline per comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:gcp Google Cloud Platform

5 participants