Skip to content

[AWS] Add Route 53 Resolver logs - #2341

Merged
kaiyan-sheng merged 4 commits into
elastic:masterfrom
legoguy1000:aws-route53-resolver
Jan 5, 2022
Merged

[AWS] Add Route 53 Resolver logs#2341
kaiyan-sheng merged 4 commits into
elastic:masterfrom
legoguy1000:aws-route53-resolver

Conversation

@legoguy1000

@legoguy1000 legoguy1000 commented Dec 14, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

Add Route 53 Resolver logs to AWS integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine

elasticmachine commented Dec 22, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-04T20:01:00.253+0000

  • Duration: 28 min 14 sec

  • Commit: 5a60f99

Test stats 🧪

Test Results
Failed 0
Passed 323
Skipped 0
Total 323

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
parsed PTR queries
@legoguy1000
legoguy1000 marked this pull request as ready for review December 22, 2021 16:29
@legoguy1000

Copy link
Copy Markdown
Contributor Author

@kaiyan-sheng I got another one for ya :).

@kaiyan-sheng

Copy link
Copy Markdown

Maybe also change the IPs in the sample logs?

@legoguy1000

Copy link
Copy Markdown
Contributor Author

Maybe also change the IPs in the sample logs?

I changed all the IPs that elastic-package complained about to IPs listed in https://github.com/elastic/elastic-package/blob/master/internal/fields/_static/allowed_geo_ips.txt

@kaiyan-sheng

Copy link
Copy Markdown

Awesome thanks!! I was looking for that list earlier...!!

Comment thread packages/aws/_dev/build/docs/route53.md
@legoguy1000

Copy link
Copy Markdown
Contributor Author

@kaiyan-sheng when u get a chance can u take a look at the updates to the docs that I made.

@kaiyan-sheng kaiyan-sheng left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for adding the docs!

@kaiyan-sheng

Copy link
Copy Markdown

/test

@kaiyan-sheng
kaiyan-sheng merged commit 0142d61 into elastic:master Jan 5, 2022
@legoguy1000
legoguy1000 deleted the aws-route53-resolver branch January 5, 2022 20:24
@endorama endorama mentioned this pull request Apr 19, 2023
5 tasks
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants