Skip to content

[gcp] Add gcp.dns integration - #2624

Merged
andrewkroh merged 2 commits into
elastic:mainfrom
liamsennitt:main
Feb 11, 2022
Merged

[gcp] Add gcp.dns integration#2624
andrewkroh merged 2 commits into
elastic:mainfrom
liamsennitt:main

Conversation

@liamsennitt

@liamsennitt liamsennitt commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Add gcp.dns integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@elasticmachine

elasticmachine commented Feb 1, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-11T21:41:04.001+0000

  • Duration: 26 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 28
Skipped 0
Total 28

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@andrewkroh andrewkroh added enhancement New feature or request Integration:gcp Google Cloud Platform Team:Integrations Label for the Integrations team labels Feb 1, 2022
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)

Comment thread packages/gcp/data_stream/dns/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/gcp/data_stream/dns/_dev/test/pipeline/test-common-config.yml Outdated
Comment thread packages/gcp/data_stream/dns/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/gcp/data_stream/dns/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/gcp/data_stream/dns/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/gcp/data_stream/dns/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/gcp/data_stream/dns/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/gcp/data_stream/dns/elasticsearch/ingest_pipeline/default.yml Outdated
@andrewkroh

Copy link
Copy Markdown
Contributor

[2022-02-02T23:59:55.323Z] Error: error running package asset tests: could not complete test run: can't install the package: can't install the package: could not install package; API status code = 500; response body = {"statusCode":500,"error":"Internal Server Error","message":"exception: [exception] Reason: java.lang.IllegalArgumentException: script_lang not supported [javascript]"}

That script will need ported over to Painless.

@andrewkroh

Copy link
Copy Markdown
Contributor

CI errors:

one or more errors found in document: [0] field "dns.response_code" is undefined
[1] field "dns.answers" is undefined
[2] field "dns.question.type" is undefined
[3] field "dns.question.name" is undefined
[4] field "dns.resolved_ip" is undefined
[5] parsing field value failed: field "event.dataset"'s value "gcp.dns" does not match the declared constant_keyword value "gcp.audit"
[6] field "network.transport" is undefined
[7] field "service.type" is undefined
[8] field "fileset.name" is undefined
[9] field "source.address" is undefined
@liamsennitt

Copy link
Copy Markdown
Contributor Author

Sorry @andrewkroh, forgot to re-run elastic-package format.

@liamsennitt

Copy link
Copy Markdown
Contributor Author

@andrewkroh are you able to re-run the tests?

@liamsennitt

liamsennitt commented Feb 7, 2022

Copy link
Copy Markdown
Contributor Author

@andrewkroh with the CI errors, should I be updating allowed_geo_ips.txt or changing my tests to only include those IP's?

@andrewkroh

Copy link
Copy Markdown
Contributor

You should change your test data to use those IPs or private IPs.

@liamsennitt

Copy link
Copy Markdown
Contributor Author

@andrewkroh this should all be good now, thank you for being patient 😄

@andrewkroh

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh changed the title Add gcp.dns integration Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:gcp Google Cloud Platform Team:Integrations Label for the Integrations team

4 participants