Skip to content

network_traffic: fix typo - #2648

Merged
efd6 merged 3 commits into
elastic:mainfrom
efd6:nettrafspel
Feb 8, 2022
Merged

network_traffic: fix typo#2648
efd6 merged 3 commits into
elastic:mainfrom
efd6:nettrafspel

Conversation

@efd6

@efd6 efd6 commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

This fixes a typo.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

elastic-package test in network_traffic.

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations 8.1-candidate labels Feb 8, 2022
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Feb 8, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-08T21:20:23.962+0000

  • Duration: 75 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 134
Skipped 0
Total 134

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh andrewkroh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove default_field (and default_fields) entirely because it has no use within Fleet packages.

@efd6

efd6 commented Feb 8, 2022

Copy link
Copy Markdown
Contributor Author

I'll do that for this package and follow up for others with an issue.

Comment thread packages/network_traffic/changelog.yml Outdated
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
@efd6
efd6 merged commit b83b6bd into elastic:main Feb 8, 2022
@efd6
efd6 deleted the nettrafspel branch February 5, 2025 22:07
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.1-candidate bug Something isn't working, use only for issues

3 participants