Skip to content

Add missing metadata fields - #2702

Merged
ChrsMark merged 4 commits into
elastic:mainfrom
ChrsMark:add_missing_kubernetes_fields
Feb 16, 2022
Merged

Add missing metadata fields#2702
ChrsMark merged 4 commits into
elastic:mainfrom
ChrsMark:add_missing_kubernetes_fields

Conversation

@ChrsMark

Copy link
Copy Markdown
Member

What does this PR do?

Adds missing to fields to fix #2693.

cc: @MichaelKatsoulis @tetianakravchenko @mtojek

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark added the Team:Cloudnative-Monitoring Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring] label Feb 16, 2022
@ChrsMark ChrsMark self-assigned this Feb 16, 2022
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

@mtojek mtojek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking

@@ -1,7 +1,9 @@
apiVersion: batch/v1beta1
apiVersion: batch/v1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you are editing this file could you fix its name? :)

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@elasticmachine

elasticmachine commented Feb 16, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-16T09:12:26.068+0000

  • Duration: 35 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 116
Skipped 0
Total 116

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@tetianakravchenko tetianakravchenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/kubernetes/changelog.yml Outdated
- version: "1.17.2"
changes:
- description: Add missing metadata fields
type: bug

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type: bug
type: bugfix
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
ChrsMark merged commit 5e112f4 into elastic:main Feb 16, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Cloudnative-Monitoring Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring]

5 participants