Skip to content

[gcp] Remove emtpy values, names with only dots, and invalid client IPs. - #2747

Merged
marc-gr merged 4 commits into
elastic:mainfrom
marc-gr:fix_gcp
Mar 2, 2022
Merged

[gcp] Remove emtpy values, names with only dots, and invalid client IPs.#2747
marc-gr merged 4 commits into
elastic:mainfrom
marc-gr:fix_gcp

Conversation

@marc-gr

@marc-gr marc-gr commented Feb 28, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Some gcp events contain keys that are formed only by dots, and also can contain invalid ip fields. This change cleans up both.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@elasticmachine

elasticmachine commented Feb 28, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-02T09:40:36.278+0000

  • Duration: 27 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 28
Skipped 0
Total 28

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
P1llus
P1llus reviewed Feb 28, 2022
View reviewed changes
Comment thread packages/gcp/data_stream/audit/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/gcp/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
@marc-gr
marc-gr requested a review from P1llus March 1, 2022 10:54
P1llus
P1llus approved these changes Mar 1, 2022
View reviewed changes
Comment thread packages/gcp/data_stream/audit/fields/fields.yml Outdated
@marc-gr
marc-gr merged commit 0136946 into elastic:main Mar 2, 2022
@marc-gr
marc-gr deleted the fix_gcp branch March 2, 2022 10:09
@andrewkroh andrewkroh mentioned this pull request Mar 7, 2022
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@marc-gr
[gcp] Remove emtpy values, names with only dots, and invalid client I…
7936aa7 
…Ps. (elastic#2747)

* Remove emtpy values, names with only dots, and invalid client IPs.

* Keep raw client ip, add description, and override orchestrator fields

* Re generate README.md

* Remove newlines from field descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@marc-gr @elasticmachine @P1llus