Add new datasets to Cisco and Fortinet packages for 7.10 - #279
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
|
fearful-symmetry
approved these changes
Oct 1, 2020
fearful-symmetry
left a comment
fearful-symmetry
left a comment
Contributor
There was a problem hiding this comment.
The stream files are a tad outside my expertise, but otherwise LGTM.
Contributor
|
This will conflict with #280, so we might want to wait for that to merge then fix. |
It's error-prone to leave it enabled by default as it requires specific configuration, otherwise Filebeat will be trying to read a file that doesn't exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds the following new datasets:
merakifortimailfortimanagerAlso it disables by default the file input on those packages.
Checklist
Screenshots