Skip to content

[azure] Added forwarded tag for Azure logs - #2822

Merged
andrewkroh merged 14 commits into
elastic:mainfrom
LaZyDK:master
Mar 29, 2022
Merged

[azure] Added forwarded tag for Azure logs#2822
andrewkroh merged 14 commits into
elastic:mainfrom
LaZyDK:master

Conversation

@LaZyDK

@LaZyDK LaZyDK commented Mar 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Added forwarded tags for Azure logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
LaZyDK added 7 commits March 14, 2022 09:03
@LaZyDK
Update manifest.yml
59faa3c 
Added forwarded tag for Azure audit logs
@LaZyDK
Merge branch 'elastic:main' into master
9c26298
@LaZyDK
Update manifest.yml
b6112e8 
Added forwarded tag for Azure activity logs
@LaZyDK
Update manifest.yml
2b9433b 
Added forwarded tag for Azure Eventhub logs
@LaZyDK
Update manifest.yml
6ace60c 
Added forwarded tag for Azure platform logs
@LaZyDK
Update manifest.yml
b6af454 
Added forwarded tag for Azure signin logs
@LaZyDK
Update manifest.yml
a8406d6 
Added forwarded tag for Azure springcloud logs
@LaZyDK
LaZyDK requested a review from a team as a code owner March 14, 2022 08:17
@elasticmachine

elasticmachine commented Mar 14, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-29T11:04:41.800+0000

  • Duration: 11 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 85
Skipped 0
Total 85

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@andrewkroh andrewkroh added enhancement New feature or request Integration:azure Azure Logs labels Mar 14, 2022
@andrewkroh

andrewkroh commented Mar 14, 2022

Copy link
Copy Markdown
Contributor

/test
@andrewkroh andrewkroh changed the title Added forwarded tag for Azure logs Mar 14, 2022
@andrewkroh

andrewkroh commented Mar 14, 2022

Copy link
Copy Markdown
Contributor

Hi @LaZyDK, can you add an entry to the changelog.yml file and bump the version in the manifest.yml to match.
@LaZyDK

LaZyDK commented Mar 16, 2022

Copy link
Copy Markdown
Contributor Author

@andrewkroh Done :)
andrewkroh
andrewkroh reviewed Mar 16, 2022
View reviewed changes
Comment thread packages/azure/changelog.yml Outdated
@andrewkroh

andrewkroh commented Mar 16, 2022

Copy link
Copy Markdown
Contributor

/test
andrewkroh
andrewkroh reviewed Mar 16, 2022
View reviewed changes

@andrewkroh andrewkroh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see what CI testing says. There might be some expected test files that need updated to include new tag (e.g. cd packages/azure && elastic-package test pipeline --generate).
@andrewkroh

andrewkroh commented Mar 16, 2022

Copy link
Copy Markdown
Contributor

/test
andrewkroh
andrewkroh approved these changes Mar 16, 2022
View reviewed changes

@andrewkroh andrewkroh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Requires review from @elastic/obs-cloud-monitoring.
kaiyan-sheng
kaiyan-sheng approved these changes Mar 28, 2022
View reviewed changes

@kaiyan-sheng kaiyan-sheng left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello sorry for the late response here! @LaZyDK Could you fix the conflict please? Thank you!!
@LaZyDK

LaZyDK commented Mar 29, 2022

Copy link
Copy Markdown
Contributor Author

It has been done.
@andrewkroh
andrewkroh merged commit 510bb1c into elastic:main Mar 29, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@LaZyDK
[azure] Added forwarded tag for Azure logs (elastic#2822)
6c09620 
Added `forwarded` tags for Azure logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:azure Azure Logs

4 participants

@LaZyDK @elasticmachine @andrewkroh @kaiyan-sheng