Skip to content

Import zoom module from Filebeat - #284

Merged
adriansr merged 14 commits into
elastic:masterfrom
adriansr:add_zoom_pkg
Oct 2, 2020
Merged

Import zoom module from Filebeat#284
adriansr merged 14 commits into
elastic:masterfrom
adriansr:add_zoom_pkg

Conversation

@adriansr

@adriansr adriansr commented Oct 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This imports the zoom module (webhook dataset) from Filebeat.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Author's Checklist

  • Categories are correct (main manifest.yml), currently security and productivity.

How to test this PR locally

You can send to it events from <beats>/x-pack/filebeat/module/zoom/webhook/test/*.log using an HTTP POST with Content-Type: application/json.

Screenshots

Screen Shot 2020-10-01 at 18 32 50

Screenshot_2020-10-01 Zoom - Integrations - Fleet - Elastic

Screenshot_2020-10-01 Add integration - Zoom - Integrations - Fleet - Elastic
@adriansr adriansr added the enhancement New feature or request label Oct 1, 2020
@elasticmachine

elasticmachine commented Oct 1, 2020 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #284 updated]

  • Start Time: 2020-10-02T09:15:23.911+0000

  • Duration: 4 min 43 sec
andrewkroh
andrewkroh approved these changes Oct 1, 2020
View reviewed changes

@andrewkroh andrewkroh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@mtojek
mtojek self-requested a review October 2, 2020 06:27
mtojek
mtojek suggested changes Oct 2, 2020
View reviewed changes

@mtojek mtojek left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the PR accordingly to changes introduced in #280 .

Main changes:

  1. Rebase against master.
  2. Rename "dataset" folder to "data_stream".
  3. Rename "config_templates" to "policy_templates" in package manifest file.
@andresrc andresrc added the Team:SIEM (Deprecated) label Oct 2, 2020
@elasticmachine

elasticmachine commented Oct 2, 2020

Copy link
Copy Markdown

Pinging @elastic/siem (Team:SIEM)
@adriansr
adriansr merged commit 736c339 into elastic:master Oct 2, 2020
@andrewkroh andrewkroh added Integration:zoom Zoom New Integration Issue or pull request for creating a new integration package. labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:zoom Zoom New Integration Issue or pull request for creating a new integration package. Team:SIEM (Deprecated)

5 participants

@adriansr @elasticmachine @andrewkroh @mtojek @andresrc