Skip to content

[mimecast] Update ECS version to 8.2 with email fields - #2841

Merged
andrewkroh merged 13 commits into
elastic:mainfrom
djordje-adzemovic-devtech:updateecsto8.2
Apr 6, 2022
Merged

[mimecast] Update ECS version to 8.2 with email fields#2841
andrewkroh merged 13 commits into
elastic:mainfrom
djordje-adzemovic-devtech:updateecsto8.2

Conversation

@djordje-adzemovic-devtech

@djordje-adzemovic-devtech djordje-adzemovic-devtech commented Mar 17, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Update ecs verion to 8.2 and implementing best practice for ingesting email fields in pipelines

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@djordje-adzemovic-devtech
djordje-adzemovic-devtech requested a review from a team as a code owner March 17, 2022 13:42
@elasticmachine

elasticmachine commented Mar 17, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-05T06:47:36.697+0000

  • Duration: 17 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 61
Skipped 0
Total 61

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
efd6
efd6 previously requested changes Mar 17, 2022
Comment thread packages/mimecast/data_stream/dlp_logs/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/mimecast/data_stream/siem_logs/elasticsearch/ingest_pipeline/default.yml Outdated
@efd6

efd6 commented Mar 17, 2022

Copy link
Copy Markdown
Contributor

/test

@efd6

efd6 commented Mar 18, 2022

Copy link
Copy Markdown
Contributor

/test

Comment thread packages/mimecast/changelog.yml Outdated
@efd6

efd6 commented Mar 20, 2022

Copy link
Copy Markdown
Contributor

Please run elastic-package build to bring the README.md up-to-date.

@taylor-swanson taylor-swanson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylor-swanson

Copy link
Copy Markdown
Contributor

/test

- mimecast.as.asn
- mimecast.organization_name
- mimecast.event_info_parts
- mimecast.rest_of_event_info

@efd6 efd6 Mar 21, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this line back in. After that LGTM.

@efd6

efd6 commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

/test

@efd6

efd6 commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

@djordje-adzemovic-devtech You will need to update the generated docs: README.md is outdated. Rebuild the package with 'elastic-package build' from the CI.

@djordje-adzemovic-devtech

Copy link
Copy Markdown
Contributor Author

Is this ok to be merged? @efd6 @taylor-swanson

Comment thread packages/mimecast/docs/README.md
@andrewkroh andrewkroh changed the title Update ecs verion to 8.2 and implementing best practice for ingesting… Mar 30, 2022
@andrewkroh

Copy link
Copy Markdown
Contributor

/test

@efd6

efd6 commented Apr 3, 2022

Copy link
Copy Markdown
Contributor

/test

@andrewkroh andrewkroh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will wait for an approval from @efd6 then it can be merged.

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@andrewkroh
andrewkroh merged commit b0f94db into elastic:main Apr 6, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Update ecs verion to 8.2 and implementing best practice for ingesting email fields in pipelines

* Removing commented code

* Remove <> if emails are empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants