Skip to content

[m365_defender] New Package - #2854

Merged
P1llus merged 7 commits into
elastic:mainfrom
P1llus:package_m365_defender
Mar 23, 2022
Merged

[m365_defender] New Package#2854
P1llus merged 7 commits into
elastic:mainfrom
P1llus:package_m365_defender

Conversation

@P1llus

@P1llus P1llus commented Mar 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

This copies over the m365_defender filebeat fileset over to its own package, with some smaller modifications.

Integration has been tested manually as well by myself.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

Overview:
image

Settings:
image

Related Issues

Closes #936
@P1llus
P1llus requested a review from a team March 21, 2022 12:23
@P1llus
P1llus requested a review from a team as a code owner March 21, 2022 12:23
@elasticmachine

elasticmachine commented Mar 21, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine

elasticmachine commented Mar 21, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-22T20:14:32.879+0000

  • Duration: 13 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
mtojek
mtojek approved these changes Mar 21, 2022
View reviewed changes

@mtojek mtojek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODEOWNERS is valid.
@P1llus
P1llus requested a review from a team March 21, 2022 14:42
adriansr
adriansr suggested changes Mar 21, 2022
View reviewed changes

@adriansr adriansr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions and small things.
Comment thread packages/m365_defender/data_stream/log/agent/stream/httpjson.yml.hbs Outdated
Comment thread packages/m365_defender/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/m365_defender/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/m365_defender/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/m365_defender/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/m365_defender/data_stream/log/fields/fields.yml Outdated
@P1llus
P1llus requested a review from adriansr March 22, 2022 08:24
@andrewkroh

andrewkroh commented Mar 22, 2022

Copy link
Copy Markdown
Contributor

Relates: #936
@andrewkroh andrewkroh linked an issue Mar 22, 2022 that may be closed by this pull request
Migrate Microsoft M365 Defender module #936
Closed
13 tasks
adriansr
adriansr approved these changes Mar 23, 2022
View reviewed changes

@adriansr adriansr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@P1llus
P1llus merged commit 1195234 into elastic:main Mar 23, 2022
@andrewkroh andrewkroh added Integration:m365_defender Microsoft Defender XDR New Integration Issue or pull request for creating a new integration package. labels Aug 13, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@P1llus @adriansr
[m365_defender] New Package (elastic#2854)
a83df71 
* Initial release of m365_defender package

* update logo

* changelog

* Update codeowners

* adding null checks for comments

* Update packages/m365_defender/data_stream/log/agent/stream/httpjson.yml.hbs

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>

* update pipeline and descriptions

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:m365_defender Microsoft Defender XDR New Integration Issue or pull request for creating a new integration package.

6 participants

@P1llus @elasticmachine @andrewkroh @mtojek @adriansr @marc-gr