[cisco_secure_endpoint] Fix propagation of information from host.name - #2915
Merged
Conversation
Referenced pull request
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Contributor
|
/test |
andrewkroh
reviewed
Mar 30, 2022
…/ingest_pipeline/default.yml Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
…/ingest_pipeline/default.yml Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Member
|
/test |
[git-generate] cd packages/cisco_secure_endpoint elastic-package build elastic-package test pipeline -g
andrewkroh
suggested changes
Apr 6, 2022
andrewkroh
left a comment
andrewkroh
left a comment
Contributor
There was a problem hiding this comment.
We need some test data to validate the new command_line parsing script processors.
I pushed some updates to make the pipeline valid, added descriptions, added two missing event.* fields, and generated the pipeline test data.
Contributor
|
/test |
Changed the script processor to fix a bug. The backing array is immutable to removeIf fails. Unhandled Exception unsupported_operation_exception remove Stack: [ "java.base/java.util.Iterator.remove(Iterator.java:102)", "java.base/java.util.Collection.removeIf(Collection.java:577)", "arg -> (arg == \"\"));\n ", "^---- HERE" ]
andrewkroh
previously approved these changes
Apr 6, 2022
[git-generate] cd packages/cisco_secure_endpoint elastic-package test pipeline -g
andrewkroh
approved these changes
Apr 6, 2022
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
Propagating information from the host.name field. Also taking into account that Install Started events use the cisco.secure_endpoint.hostname field. Adding process.command_line, process.args, process.args_count and process.executable from cisco.secure_endpoint.command_line.arguments field. Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Propagating information from the host.name field.
Also taking into account that
Install Startedevents use thecisco.secure_endpoint.hostnamefield.Adding
process.command_line,process.args,process.args_countandprocess.executablefromcisco.secure_endpoint.command_line.argumentsfield.Checklist
changelog.ymlfile.