Skip to content

Spring boot package [GC - data stream] - #2982

Merged
mtojek merged 10 commits into
elastic:mainfrom
sunny-elastic:package_spring_boot_gc
Apr 28, 2022
Merged

Spring boot package [GC - data stream]#2982
mtojek merged 10 commits into
elastic:mainfrom
sunny-elastic:package_spring_boot_gc

Conversation

@sunny-elastic

@sunny-elastic sunny-elastic commented Apr 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Generated the skeleton of Spring Boot integration package.
  • Added GC data stream
  • Added data collection logic.
  • Added the ingest pipelines.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files.
  • Added system test cases.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that GC data stream collect metrics.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^8.0.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/spring_boot directory.
  • Run the following command to run tests.

elastic-package test

Note: We have covered dashboards and the visualisations for all data streams of spring boot into separate PR. Also Kibana version will be updated to 8.1.0 in manifest.yml after testing this integration on 8.1.0.
@sunny-elastic
sunny-elastic requested a review from a team as a code owner April 3, 2022 08:02
@elasticmachine

elasticmachine commented Apr 3, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-28T10:14:20.725+0000

  • Duration: 19 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@sunny-elastic sunny-elastic self-assigned this Apr 3, 2022
@sunny-elastic sunny-elastic added enhancement New feature or request Team:Integrations Label for the Integrations team New Integration Issue or pull request for creating a new integration package. labels Apr 3, 2022
@elasticmachine

elasticmachine commented Apr 3, 2022

Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)
@sunny-elastic
sunny-elastic requested a review from mtojek April 3, 2022 12:47
@mtojek
mtojek requested a review from ruflin April 4, 2022 09:35
mtojek
mtojek reviewed Apr 4, 2022
View reviewed changes
Comment thread packages/spring_boot/data_stream/gc/manifest.yml Outdated
Comment thread packages/spring_boot/data_stream/gc/sample_event.json Outdated
Comment thread packages/spring_boot/data_stream/gc/sample_event.json Outdated
Comment thread packages/spring_boot/data_stream/gc/sample_event.json Outdated
"count": 2,
"time": 107
},
"last_gc_info": {

@mtojek mtojek Apr 4, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed a similar GC structure for Spark. Could you please make it consistent with other integrations? PR: https://github.com/elastic/integrations/pull/2811/files#r837067908

@sunny-elastic sunny-elastic Apr 7, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so this structure is different here. here last_gc_info is an object.
@sunny-elastic
sunny-elastic requested a review from a team as a code owner April 20, 2022 17:10
@elasticmachine

elasticmachine commented Apr 27, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 100.0% (27/27) 💚
Lines 93.289% (139/149) ❕
Conditionals 100.0% (0/0) 💚
yug-rajani
yug-rajani reviewed Apr 28, 2022
View reviewed changes

@yug-rajani yug-rajani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nitpicks and some things to clarify, LGTM otherwise.
Please wait for a review from others as well.
Comment thread packages/spring_boot/_dev/build/docs/README.md Outdated
Comment thread packages/spring_boot/data_stream/gc/elasticsearch/ingest_pipeline/default.yml
@sunny-elastic
sunny-elastic requested review from yug-rajani and removed request for kush-elastic April 28, 2022 08:09
yug-rajani
yug-rajani approved these changes Apr 28, 2022
View reviewed changes

@yug-rajani yug-rajani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for @mtojek's re-review over the same.
mtojek
mtojek approved these changes Apr 28, 2022
View reviewed changes

@mtojek mtojek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Comment thread packages/spring_boot/_dev/build/docs/README.md Outdated

This is the `gc` data stream.

- This data stream gives metrics related to Garbage Collector(GC) Memory.

@mtojek mtojek Apr 28, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: to Garbage Collector (GC).

@sunny-elastic sunny-elastic Apr 28, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed
@mtojek
mtojek merged commit 653a14b into elastic:main Apr 28, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@sunny-elastic @yug-rajani
Spring boot package [GC - data stream] (elastic#2982)
f41862f 
* Spring boot package [GC - data stream]

* addressed review comments

* update CODEOWNER and manifest

* updated descriptions in field.yml

* update title and descriptions

* update Dockerfile to mute verbose logs

* update README.md

Co-authored-by: yug-elastic <96041884+yug-elastic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request New Integration Issue or pull request for creating a new integration package. Team:Integrations Label for the Integrations team

4 participants

@sunny-elastic @elasticmachine @mtojek @yug-rajani