Skip to content

Update Netflow readme - #3002

Merged
andrewkroh merged 26 commits into
elastic:mainfrom
GinnyGalicia:netflow-docs
Aug 15, 2022
Merged

Update Netflow readme #3002
andrewkroh merged 26 commits into
elastic:mainfrom
GinnyGalicia:netflow-docs

Conversation

@cherryleaf

@cherryleaf cherryleaf commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

Type of change

  • Enhancement

What does this PR do?

Tidy up of Markdown in Readme.md, including adding link to developer's documentation, if missing

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

GinnyGalicia and others added 7 commits March 10, 2022 13:27
Changed headings to correct markdown syntax
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.7.0...v1.7.1)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Markdown tidy up of readme file
To avoid clashes
update to reset main branch and stop files being added to PRs
Tidy up of Markdown in Readme.md, including adding link to developer's documentation, if missing
@cherryleaf
cherryleaf requested a review from a team as a code owner April 5, 2022 14:34
@elasticmachine

elasticmachine commented Apr 5, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-15T14:52:52.920+0000

  • Duration: 20 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 92
Skipped 0
Total 92

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
dependabot Bot and others added 9 commits April 5, 2022 14:40
Bumps [github.com/elastic/package-registry](https://github.com/elastic/package-registry) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/elastic/package-registry/releases)
- [Changelog](https://github.com/elastic/package-registry/blob/main/CHANGELOG.md)
- [Commits](elastic/package-registry@v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/elastic/package-registry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…com/elastic/package-registry-1.8.0

Bump github.com/elastic/package-registry from 1.7.0 to 1.8.0
…com/stretchr/testify-1.7.1

Bump github.com/stretchr/testify from 1.7.0 to 1.7.1
Bumps [github.com/magefile/mage](https://github.com/magefile/mage) from 1.11.0 to 1.13.0.
- [Release notes](https://github.com/magefile/mage/releases)
- [Changelog](https://github.com/magefile/mage/blob/master/.goreleaser.yml)
- [Commits](magefile/mage@v1.11.0...v1.13.0)

---
updated-dependencies:
- dependency-name: github.com/magefile/mage
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…com/magefile/mage-1.13.0

Bump github.com/magefile/mage from 1.11.0 to 1.13.0
Bumps [github.com/elastic/elastic-package](https://github.com/elastic/elastic-package) from 0.38.0 to 0.46.0.
- [Release notes](https://github.com/elastic/elastic-package/releases)
- [Changelog](https://github.com/elastic/elastic-package/blob/main/.goreleaser.yml)
- [Commits](elastic/elastic-package@v0.38.0...v0.46.0)

---
updated-dependencies:
- dependency-name: github.com/elastic/elastic-package
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…com/elastic/elastic-package-0.46.0

Bump github.com/elastic/elastic-package from 0.38.0 to 0.46.0
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@bmorelli25

Copy link
Copy Markdown
Member

/test

Comment thread packages/netflow/changelog.yml Outdated
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
Comment thread packages/1password/_dev/build/docs/README.md Outdated
Comment thread packages/netflow/changelog.yml
@r00tu53r r00tu53r added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Apr 12, 2022
@efd6

efd6 commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

/test

Comment thread packages/netflow/_dev/build/docs/README.md Outdated
@andrewkroh andrewkroh added the conflicts There is a conflict in the backported pull request label Jul 20, 2022
ellis-elastic and others added 3 commits August 9, 2022 16:30
@efd6

efd6 commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

/test

@andrewkroh

Copy link
Copy Markdown
Contributor

README.md is outdated. Rebuild the package with 'elastic-package build'
[2022-08-10T04:03:55.675Z] Error: checking package failed: checking readme files are up-to-date failed: checking readme files are up-to-date failed

@GinnyGalicia can you please regenerate the README file with elastic-package build.

@GinnyGalicia

Copy link
Copy Markdown
Contributor

Ran build again

@andrewkroh

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.941
Classes 100.0% (1/1) 💚 2.941
Methods 100.0% (7/7) 💚 10.5
Lines 100.0% (56/56) 💚 8.472
Conditionals 100.0% (0/0) 💚
@andrewkroh
andrewkroh merged commit 7c181cc into elastic:main Aug 15, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Add links to Netflow V9 and IPFIX RFCs.

Co-authored-by: GinnyC <92439019+GinnyGalicia@users.noreply.github.com>
Co-authored-by: cherryleaf-ginny <ginny@cherryleaf.com>
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
Co-authored-by: cherryleaf-ellis <ellis.pratt@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts There is a conflict in the backported pull request documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:netflow NetFlow Records

8 participants