Skip to content

Update Atlassian Jira Readme - #3063

Merged
ellis-elastic merged 10 commits into
elastic:mainfrom
ellis-elastic:Atlassian-jira-docs
Apr 14, 2022
Merged

Update Atlassian Jira Readme#3063
ellis-elastic merged 10 commits into
elastic:mainfrom
ellis-elastic:Atlassian-jira-docs

Conversation

@ellis-elastic

@ellis-elastic ellis-elastic commented Apr 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Added link to Atlassian documentation

Type of change

  • Enhancement

What does this PR do?

Added link to Atlassian documentation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@GinnyGalicia
Update Readme
2627445 
Added link to Atlassian documentation
@ellis-elastic
ellis-elastic requested a review from a team as a code owner April 11, 2022 15:40
@elasticmachine

elasticmachine commented Apr 11, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-13T14:32:03.788+0000

  • Duration: 13 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@efd6

efd6 commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

/test
@r00tu53r r00tu53r added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:atlassian_jira Atlassian Jira Team:Security-External Integrations labels Apr 12, 2022
@elasticmachine

elasticmachine commented Apr 12, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
andrewkroh
andrewkroh reviewed Apr 12, 2022
View reviewed changes
Comment thread packages/atlassian_jira/changelog.yml Outdated
r00tu53r
r00tu53r reviewed Apr 13, 2022
View reviewed changes

@r00tu53r r00tu53r left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deletions indicated in docs/README.md for field docs (host.os.name.text ..... user.target.name.text) shouldn't be here.

I think its because the updated docs/README.md has not been committed/pushed. Please apply these steps for all the open PRs.

  • Change readme under _dev/build/docs/README.md (if it exists)
  • Run elastic-package build
  • Commit _dev/build/docs/README.md and docs/README.md
  • Push changes
@ellis-elastic
Update changelog
95edb84 
Fixed typo
@ellis-elastic

ellis-elastic commented Apr 13, 2022

Copy link
Copy Markdown
Contributor Author

@r00tu53r r00tu53r I did run build on the files.
@ellis-elastic
Update readme
2ce28b8 
Added a space so I can re run build
@ellis-elastic
Re ran build
f76b731
@ellis-elastic

ellis-elastic commented Apr 13, 2022

Copy link
Copy Markdown
Contributor Author

I've added a space to the readme file so I could re run build
@r00tu53r

r00tu53r commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

/test
@r00tu53r

r00tu53r commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

I've added a space to the readme file so I could re run build

@ellis-elastic there is no need to add space or make a spurious change to trigger the build. I suspect that your elastic-package version is old or the cache (under ~/.elastic-package) is not ok. I've pushed the changes to this one to fix the problem.

You could try this on the next/other PR -

  • Remove the cache
    rm -rf ~/.elastic-package

  • Rebuild
    elastic-package build
r00tu53r
r00tu53r reviewed Apr 13, 2022
View reviewed changes
Comment thread packages/atlassian_jira/_dev/build/docs/README.md Outdated
@r00tu53r

r00tu53r commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

/test
1 similar comment
@r00tu53r

r00tu53r commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

/test
@ellis-elastic
Update Readme
0d126da 
Updated link to Atlassian documentation
@ellis-elastic
Merge branch 'Atlassian-jira-docs' of https://github.com/ellis-elasti…
771d47a 
…c/integrations into Atlassian-jira-docs
@ellis-elastic
ran build
6d26682
@ellis-elastic
Update Readme using build
a16a1c9 
Using v0.46.1 of Elastic-package
@ellis-elastic

ellis-elastic commented Apr 13, 2022

Copy link
Copy Markdown
Contributor Author

I've installed v0.46.1 and rerun build
@v1v

v1v commented Apr 13, 2022

Copy link
Copy Markdown
Member

/test
1 similar comment
@v1v

v1v commented Apr 13, 2022

Copy link
Copy Markdown
Member

/test
r00tu53r
r00tu53r approved these changes Apr 14, 2022
View reviewed changes

@r00tu53r r00tu53r left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ellis-elastic
ellis-elastic merged commit a1ae4e7 into elastic:main Apr 14, 2022
@andrewkroh andrewkroh mentioned this pull request Apr 18, 2022
Merged
@ellis-elastic
ellis-elastic deleted the Atlassian-jira-docs branch April 19, 2022 14:30
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@ellis-elastic @GinnyGalicia @r00tu53r
Update Atlassian Jira Readme (elastic#3063)
4693222 
* Update Readme

Added link to Atlassian documentation

* Update changelog and ran build

* Update changelog

Fixed typo

* Update readme

Added a space so I can re run build

* Re ran build

* remove extra space and commit generated readme

* Update Readme

Updated link to Atlassian documentation

* ran build

* Update Readme using build

Using v0.46.1 of Elastic-package

Co-authored-by: cherryleaf-ginny <ginny@cherryleaf.com>
Co-authored-by: Sai Kiran <85323324+r00tu53r@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:atlassian_jira Atlassian Jira

7 participants

@ellis-elastic @elasticmachine @efd6 @r00tu53r @v1v @andrewkroh @GinnyGalicia