Skip to content

[Multiple Packages] adding change to forwarded tag template to multiple packages - #3092

Merged
P1llus merged 2 commits into
elastic:mainfrom
P1llus:packages_fix_forwarded_template
Apr 13, 2022
Merged

[Multiple Packages] adding change to forwarded tag template to multiple packages#3092
P1llus merged 2 commits into
elastic:mainfrom
P1llus:packages_fix_forwarded_template

Conversation

@P1llus

@P1llus P1llus commented Apr 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

The format used to check if publisher_pipeline.disable_host: true should be used is incorrect

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@P1llus P1llus added bug Something isn't working, use only for issues Team:Security-External Integrations Team:Service-Integrations Label for the Observability Service Integrations team labels Apr 13, 2022
@P1llus
P1llus requested review from a team as code owners April 13, 2022 14:51
@elasticmachine

elasticmachine commented Apr 13, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@P1llus

P1llus commented Apr 13, 2022

Copy link
Copy Markdown
Member Author

Added a fix for timestamp field mapping as well for the github package to get the CI to pass, they are usually added to base-fields.yml rather than ecs.yml for now.
@andrewkroh

andrewkroh commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

The format used to check if add_host_metadata processor should run or not, for some packages, was wrong

It doesn't affect add_host_metadata. It looks like it affects whether publisher_pipeline.disable_host: true is added.
andrewkroh
andrewkroh approved these changes Apr 13, 2022
View reviewed changes
Comment thread packages/github/data_stream/audit/fields/ecs.yml
@@ -1,5 +1,3 @@
- name: "@timestamp"

@andrewkroh andrewkroh Apr 13, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be preferred, but it's not supported because of elastic/elastic-package#749.
@elasticmachine

elasticmachine commented Apr 13, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-13T14:52:13.309+0000

  • Duration: 17 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 111
Skipped 0
Total 111

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@P1llus
P1llus merged commit 74b40f9 into elastic:main Apr 13, 2022
@andrewkroh andrewkroh mentioned this pull request Apr 18, 2022
Merged
@andrewkroh andrewkroh mentioned this pull request May 2, 2022
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@P1llus
[Multiple Packages] adding change to forwarded tag template to multip…
48607b8 
…le packages (elastic#3092)

* adding change to forwarded tag template to multiple packages

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Team:Service-Integrations Label for the Observability Service Integrations team

4 participants

@P1llus @elasticmachine @andrewkroh @kaiyan-sheng