[netskope] Fix: dropping event due to new response from Netskope API. - #3110
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
vinit-chauhan
changed the title
Contributor
|
/test |
andrewkroh
added
bug
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
reviewed
Apr 15, 2022
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Contributor
|
/test |
Contributor
|
/test |
andrewkroh
approved these changes
Apr 15, 2022
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
…elastic#3110) Fix boolean conversion logic to accept "true", "false", "yes", and "no" as strings. Correct the type of `is_alert` and `is_web_universal_connector` to boolean.
Closed
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the Netskope response previously the response had
trueas a value for the fieldnetskope.events.user.generated. Now the API response is updated to sendyesinstead, resulting in the pipeline failure.In this PR we have added conversions for true/false and yes/no to all the boolean fields so that such API changes for other fields can also be handled.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Clone integrations repo.
Install elastic-package locally.
Start elastic stack using elastic-package.
Move to integrations/packages/netskope directory.
Run the following command to run tests.
elastic-package testRelated issues
Screenshots