Skip to content

update QNAP NAS readme - #3155

Merged
ellis-elastic merged 4 commits into
elastic:mainfrom
ellis-elastic:qnap_nas-docs
Jun 9, 2022
Merged

update QNAP NAS readme#3155
ellis-elastic merged 4 commits into
elastic:mainfrom
ellis-elastic:qnap_nas-docs

Conversation

@ellis-elastic

@ellis-elastic ellis-elastic commented Apr 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

added link to QNAP documentation

Type of change

  • Enhancement

What does this PR do?

added link to QNAP documentation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@ellis-elastic
update readme
675fcb6 
added link to QNAP documentation
@ellis-elastic ellis-elastic added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request labels Apr 21, 2022
@ellis-elastic
ellis-elastic requested a review from a team as a code owner April 21, 2022 08:02
@ellis-elastic
ellis-elastic marked this pull request as draft April 21, 2022 08:02
@elasticmachine

elasticmachine commented Apr 21, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-18T13:25:25.952+0000

  • Duration: 18 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@ellis-elastic
ellis-elastic marked this pull request as ready for review April 22, 2022 08:19
@elasticmachine

elasticmachine commented Apr 27, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.589
Classes 100.0% (1/1) 💚 3.589
Methods 100.0% (14/14) 💚 11.711
Lines 95.142% (235/247) 👍 6.124
Conditionals 100.0% (0/0) 💚
@elasticmachine

elasticmachine commented Jun 7, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
leehinman
leehinman approved these changes Jun 7, 2022
View reviewed changes

@leehinman leehinman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ellis-elastic
ellis-elastic merged commit 3cc9030 into elastic:main Jun 9, 2022
@ellis-elastic
ellis-elastic deleted the qnap_nas-docs branch June 9, 2022 10:42
@andrewkroh andrewkroh mentioned this pull request Jun 9, 2022
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@ellis-elastic @bmorelli25
update QNAP NAS readme (elastic#3155)
ac2476a 
* update readme

added link to QNAP documentation

* update changelog and ran build

* update readme, ran build

Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request

5 participants

@ellis-elastic @elasticmachine @bmorelli25 @leehinman @epixa