Skip to content

Update tenable.sc readme - #3165

Merged
bmorelli25 merged 8 commits into
elastic:mainfrom
ellis-elastic:tenable-sc-docs
Jun 24, 2022
Merged

Update tenable.sc readme#3165
bmorelli25 merged 8 commits into
elastic:mainfrom
ellis-elastic:tenable-sc-docs

Conversation

@ellis-elastic

@ellis-elastic ellis-elastic commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

added links to tenable documentation and made the English clearer.

Type of change

  • Enhancement

What does this PR do?

added links to tenable documentation and made the English clearer.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

added links to tenable documentation and made the English clearer.
@ellis-elastic ellis-elastic added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request labels Apr 21, 2022
@ellis-elastic
ellis-elastic requested a review from a team as a code owner April 21, 2022 14:21
@ellis-elastic
ellis-elastic marked this pull request as draft April 21, 2022 14:21
@elasticmachine

elasticmachine commented Apr 21, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-24T07:52:53.698+0000

  • Duration: 16 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 38
Skipped 0
Total 38

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@ellis-elastic
ellis-elastic marked this pull request as ready for review April 22, 2022 08:19
Comment thread packages/tenable_sc/_dev/build/docs/README.md Outdated
Comment thread packages/tenable_sc/_dev/build/docs/README.md Outdated
@elasticmachine

elasticmachine commented Apr 27, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚 3.546
Classes 100.0% (3/3) 💚 3.546
Methods 100.0% (41/41) 💚 10.778
Lines 96.852% (923/953) 👍 5.991
Conditionals 100.0% (0/0) 💚
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Comment thread packages/tenable_sc/_dev/build/docs/README.md Outdated
fixed missing link and HTML
 reran build
Pointed users to Teanable's content.. In case the steps change the user would always have up-to-date information.

@r00tu53r r00tu53r left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request

5 participants