Skip to content

update winlog readme - #3177

Merged
ellis-elastic merged 8 commits into
elastic:mainfrom
ellis-elastic:winlog-docs
Jun 9, 2022
Merged

update winlog readme#3177
ellis-elastic merged 8 commits into
elastic:mainfrom
ellis-elastic:winlog-docs

Conversation

@ellis-elastic

@ellis-elastic ellis-elastic commented Apr 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

added link to Microsoft documentation and reworded a link

What does this PR do?

added link to Microsoft documentation and reworded a link

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@ellis-elastic
update winlog readme
13a369a 
added link to Microsoft documentation and reworded a link
@ellis-elastic ellis-elastic added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request labels Apr 22, 2022
@ellis-elastic
ellis-elastic requested a review from a team as a code owner April 22, 2022 10:08
@ellis-elastic
ellis-elastic marked this pull request as draft April 22, 2022 10:09
@elasticmachine

elasticmachine commented Apr 22, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-18T13:24:54.235+0000

  • Duration: 16 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@ellis-elastic
ellis-elastic marked this pull request as ready for review April 25, 2022 12:12
@elasticmachine

elasticmachine commented Apr 27, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.589
Classes 100.0% (0/0) 💚 3.589
Methods 66.667% (2/3) 👎 -21.622
Lines 100.0% (0/0) 💚 10.983
Conditionals 100.0% (0/0) 💚
@elasticmachine

elasticmachine commented Jun 7, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
leehinman
leehinman approved these changes Jun 7, 2022
View reviewed changes

@leehinman leehinman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ellis-elastic
ellis-elastic merged commit 6e88b3b into elastic:main Jun 9, 2022
@ellis-elastic
ellis-elastic deleted the winlog-docs branch June 9, 2022 10:39
@andrewkroh andrewkroh mentioned this pull request Jun 9, 2022
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@ellis-elastic @bmorelli25
update winlog readme (elastic#3177)
40c654e 
* update winlog readme

added link to Microsoft documentation and reworded a link

* update changelog and ran build

* update changelog

to resolve number clash

* Update README.md

* Update README.md

* Update changelog.yml

* Update manifest.yml

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request

5 participants

@ellis-elastic @elasticmachine @bmorelli25 @leehinman @epixa