Skip to content

[m365_defender] Fix mapping for comments field and add missing fields - #3181

Merged
marc-gr merged 4 commits into
elastic:mainfrom
marc-gr:fix-m365-fields
Apr 25, 2022
Merged

[m365_defender] Fix mapping for comments field and add missing fields#3181
marc-gr merged 4 commits into
elastic:mainfrom
marc-gr:fix-m365-fields

Conversation

@marc-gr

@marc-gr marc-gr commented Apr 25, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes an incorrect mapping for the comments field and adds missing fields mappings.

Checklist

- [ ] I have reviewed tips for building integrations and this pull request is aligned with them.

  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@marc-gr marc-gr added bug Something isn't working, use only for issues Team:Security-External Integrations labels Apr 25, 2022
@marc-gr
marc-gr requested a review from a team as a code owner April 25, 2022 09:19
@elasticmachine

elasticmachine commented Apr 25, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@marc-gr
marc-gr requested a review from P1llus April 25, 2022 09:20
@elasticmachine

elasticmachine commented Apr 25, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-25T12:21:27.585+0000

  • Duration: 13 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@marc-gr
marc-gr merged commit ec7f132 into elastic:main Apr 25, 2022
@marc-gr
marc-gr deleted the fix-m365-fields branch April 25, 2022 14:00
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@marc-gr
[m365_defender] Fix mapping for comments field and add missing fields (…
609fe5d 
…elastic#3181)

* Fix mapping for comments field and add missing fields

* Add changelog entry

* Add UserSid field

* Generate readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues

3 participants

@marc-gr @elasticmachine @P1llus