Skip to content

[Proposal] Distribute ownership of packages owned by integrations - #3202

Merged
jsoriano merged 8 commits into
elastic:mainfrom
jsoriano:integrations-owners
May 11, 2022
Merged

[Proposal] Distribute ownership of packages owned by integrations#3202
jsoriano merged 8 commits into
elastic:mainfrom
jsoriano:integrations-owners

Conversation

@jsoriano

@jsoriano jsoriano commented Apr 26, 2022

Copy link
Copy Markdown
Contributor

The integrations team is now distributed along different teams. Several packages are still assigned to the integrations team and responsibilities have diluted. It is not clear what current teams are taking care of them, what teams should review changes and so on.

The proposal would be to explicitly distribute the ownership of these packages along the current teams.

Proposed changes can be summarized as:

  • Service integrations owned by @elastic/obs-service-integrations.
  • System integrations (system, windows, linux) owned by @elastic/elastic-agent-data-plane.
  • Input integrations (journald, log) owned by @elastic/elastic-agent-data-plane.
  • nginx_ingress_controller owned by @elastic/obs-cloudnative-monitoring.

Some grey areas:

  • stan, nats, etcd are services that can be used anywhere, but they are quite related to cloud native, so maybe they should be owned by the cloud native team.
  • I think that input packages make sense in the data plane team, but the truth is that these packages have been maintained so far by SEI, ecosystem and other integrations teams, so not sure what to do.
@jsoriano
jsoriano requested review from a team April 26, 2022 15:42
@jsoriano
jsoriano requested a review from a team as a code owner April 26, 2022 15:42
@jsoriano jsoriano self-assigned this Apr 26, 2022
@elasticmachine

elasticmachine commented Apr 26, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-11T08:16:20.185+0000

  • Duration: 34 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 1156
Skipped 3
Total 1159

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@jsoriano
jsoriano force-pushed the integrations-owners branch from 1927965 to 4b184c4 Compare April 26, 2022 16:01
@elasticmachine

elasticmachine commented Apr 26, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (30/30) 💚
Files 88.889% (40/45) 👎 -7.453
Classes 88.889% (40/45) 👎 -7.453
Methods 78.82% (521/661) 👎 -10.064
Lines 93.099% (9889/10622) 👍 2.997
Conditionals 100.0% (0/0) 💚
Comment thread .github/CODEOWNERS
@jsoriano
jsoriano force-pushed the integrations-owners branch from 3bfdff2 to 98f7851 Compare April 28, 2022 13:42
Comment thread .github/CODEOWNERS Outdated
@rameshelastic

Copy link
Copy Markdown

@jsoriano I don't have the historical context of how this was working earlier but Service integrations look ok in the proposal above.

@ChrsMark ChrsMark left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think nginx-ingress-controller , nats and stan should be owned by @elastic/obs-cloudnative-monitoring , since those are “cloud native” projects. Not sure about etcd. @luna can make the final call on this.

@jsoriano

jsoriano commented May 2, 2022

Copy link
Copy Markdown
Contributor Author

@ChrsMark is it possible that you wanted to ping @mlunadia on #3202 (review)? 🙂

@jsoriano
jsoriano requested a review from mlunadia May 2, 2022 14:42
@jsoriano

jsoriano commented May 9, 2022

Copy link
Copy Markdown
Contributor Author

Given the generally positive feedback I will merge this if there is no objection by tomorrow.

@jsoriano

Copy link
Copy Markdown
Contributor Author

/test

@jsoriano
jsoriano merged commit 99a8156 into elastic:main May 11, 2022
@jsoriano
jsoriano deleted the integrations-owners branch May 11, 2022 09:24
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
The integrations team is now distributed along different teams. Several packages are still assigned to the
integrations team and responsibilities have diluted. It is not clear what current teams are taking care of
them, what teams should review changes and so on.

Explicitly distribute the ownership of these packages along the current teams.

Changes can be summarized as:
* Service integrations owned by @elastic/obs-service-integrations.
* System integrations (system, windows, linux) owned by @elastic/elastic-agent-data-plane.
* Input integrations (journald, log) owned by @elastic/elastic-agent-data-plane.
* nginx_ingress_controller, nats and stan owned by @elastic/obs-cloudnative-monitoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

7 participants