Skip to content

Send dataYaml (Rules Activation YAML) to Agent - #3241

Merged
yashtewari merged 1 commit into
elastic:mainfrom
yashtewari:send-data-yaml
May 4, 2022
Merged

Send dataYaml (Rules Activation YAML) to Agent#3241
yashtewari merged 1 commit into
elastic:mainfrom
yashtewari:send-data-yaml

Conversation

@yashtewari

@yashtewari yashtewari commented May 1, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

The information in dataYaml var (which is functionally the Rules Activation YAML) is sent to cloudbeat via the Agent policy, where it can be consumed for cloudbeat to know which rules to run.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Within the package directory,

elastic-package build
elastic-package up

Create an Agent policy and view its full contents. Changes made to the dataYaml var will be reflected as data stream input in the Agent policy.

@yashtewari yashtewari added the enhancement New feature or request label May 1, 2022
@yashtewari
yashtewari requested a review from a team as a code owner May 1, 2022 07:18
@elasticmachine

elasticmachine commented May 1, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-04T08:41:14.748+0000

  • Duration: 16 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 1
Skipped 0
Total 1

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented May 1, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.39
Classes 100.0% (0/0) 💚 3.39
Methods 33.333% (1/3) 👎 -54.93
Lines 100.0% (0/0) 💚 11.098
Conditionals 100.0% (0/0) 💚

@eyalkraft eyalkraft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Please merge only after testing e2e :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails because you also need to update the versions in the manifest of each integration.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eyal!

@yashtewari
yashtewari merged commit 549b3ea into elastic:main May 4, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

3 participants