Skip to content

[Fortinet] Separate Fortinet FortiGate into own Integration - #3265

Merged
efd6 merged 12 commits into
elastic:mainfrom
legoguy1000:1936-fortinet-fortigate
Jul 25, 2022
Merged

[Fortinet] Separate Fortinet FortiGate into own Integration#3265
efd6 merged 12 commits into
elastic:mainfrom
legoguy1000:1936-fortinet-fortigate

Conversation

@legoguy1000

@legoguy1000 legoguy1000 commented May 3, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Creates an independent integration for Fortinet FortiGate logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@elasticmachine

elasticmachine commented May 3, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-25T00:02:55.350+0000

  • Duration: 19 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@legoguy1000 legoguy1000 changed the title Separate Fortinet FortiGate into own Integration May 4, 2022
@legoguy1000 legoguy1000 changed the title [Fortinet_Fortigate] Separate Fortinet FortiGate into own Integration May 4, 2022
@legoguy1000

legoguy1000 commented May 27, 2022

Copy link
Copy Markdown
Contributor Author

@andrewkroh ready for testing
@efd6

efd6 commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

/test
@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. [Integration not found in source] labels Jun 28, 2022
@elasticmachine

elasticmachine commented Jun 28, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@efd6

efd6 commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

/test
1 similar comment
@efd6

efd6 commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

/test
@legoguy1000

legoguy1000 commented Jul 10, 2022

Copy link
Copy Markdown
Contributor Author

I found and fixed the issues
@efd6

efd6 commented Jul 11, 2022

Copy link
Copy Markdown
Contributor

/test
@elasticmachine

elasticmachine commented Jul 11, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚 3.03
Classes 100.0% (4/4) 💚 3.03
Methods 100.0% (38/38) 💚 10.288
Lines 91.688% (1070/1167) 👍 0.246
Conditionals 100.0% (0/0) 💚
efd6
efd6 reviewed Jul 11, 2022
View reviewed changes
Comment thread packages/fortinet_fortigate/data_stream/log/manifest.yml Outdated
@efd6

efd6 commented Jul 11, 2022

Copy link
Copy Markdown
Contributor

/test
@legoguy1000
legoguy1000 force-pushed the 1936-fortinet-fortigate branch from 1d1321e to 24d73d9 Compare July 11, 2022 01:14
@efd6

efd6 commented Jul 11, 2022

Copy link
Copy Markdown
Contributor

/test
@efd6

efd6 commented Jul 11, 2022

Copy link
Copy Markdown
Contributor

/test
@efd6

efd6 commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

/test
@efd6
efd6 merged commit 248c5ba into elastic:main Jul 25, 2022
@elasticmachine

elasticmachine commented Jul 25, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-25T00:04:55.075+0000

  • Duration: 20 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jul 25, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚 3.03
Classes 100.0% (4/4) 💚 3.03
Methods 100.0% (38/38) 💚 10.288
Lines 91.688% (1070/1167) 👍 0.246
Conditionals 100.0% (0/0) 💚
@legoguy1000
legoguy1000 deleted the 1936-fortinet-fortigate branch July 25, 2022 01:25
@andrewkroh andrewkroh mentioned this pull request Jul 26, 2022
Merged
@andrewkroh andrewkroh added Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs New Integration Issue or pull request for creating a new integration package. and removed Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. [Integration not found in source] labels Aug 13, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@legoguy1000
[Fortinet] Separate Fortinet FortiGate into own Integration (elastic#…
dc02f79 
…3265)

* Separate Fortinet Fortigate into own Integration

* update changelog

* Update casing

* update codeowners

* format files

* fix dataset field name

* update to ECS 8.3

* found error

* update sample event

* Add TLS to tcp

* Rebase changes for TCP input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs New Integration Issue or pull request for creating a new integration package.

4 participants

@legoguy1000 @elasticmachine @efd6 @andrewkroh