Skip to content

[checkpoint] Add TLS and custom options support to TCP input - #3317

Merged
taylor-swanson merged 4 commits into
elastic:mainfrom
taylor-swanson:inputs-checkpoint
May 12, 2022
Merged

[checkpoint] Add TLS and custom options support to TCP input#3317
taylor-swanson merged 4 commits into
elastic:mainfrom
taylor-swanson:inputs-checkpoint

Conversation

@taylor-swanson

@taylor-swanson taylor-swanson commented May 10, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Add TLS support to TCP input
  • Add TCP custom options to TCP input

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/checkpoint && elastic-package test

Related issues

Screenshots

check_point

- Add TLS support to TCP input
- Add TCP custom options to TCP input
@elasticmachine

elasticmachine commented May 10, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T07:54:58.281+0000

  • Duration: 18 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 10
Skipped 0
Total 10

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented May 10, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.597
Classes 100.0% (1/1) 💚 3.597
Methods 100.0% (14/14) 💚 11.753
Lines 82.021% (625/762) 👎 -7.092
Conditionals 100.0% (0/0) 💚
@taylor-swanson
taylor-swanson marked this pull request as ready for review May 10, 2022 15:16
@taylor-swanson
taylor-swanson requested a review from a team as a code owner May 10, 2022 15:16
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@taylor-swanson
taylor-swanson merged commit 875e225 into elastic:main May 12, 2022
@taylor-swanson
taylor-swanson deleted the inputs-checkpoint branch May 12, 2022 19:47
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
…#3317)

- Add TLS support to TCP input
- Add TCP custom options to TCP input
- Add system tests for TCP/TLS input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:checkpoint Check Point

3 participants