Skip to content

[Azure] Improves IPv6 parsing, replaced grok filter with convert - #3411

Merged
ShourieG merged 8 commits into
elastic:mainfrom
ShourieG:bug/azure-issues-2138-fix
May 26, 2022
Merged

[Azure] Improves IPv6 parsing, replaced grok filter with convert #3411
ShourieG merged 8 commits into
elastic:mainfrom
ShourieG:bug/azure-issues-2138-fix

Conversation

@ShourieG

@ShourieG ShourieG commented May 23, 2022

Copy link
Copy Markdown
Contributor

Improves IPv6 parsing

What does this PR do?

  1. Added bug fix for issue [azure] Handle IPv6 addresses in activity/audit/platform logs #2138 replacing grok filter with convert in 'activitylogs' of azure package
  2. Improved IPv6 handling for other sub-packages : 'auditlogs', 'platformlogs' & 'springcloudlogs'
  3. Updated ecs.yml file for springcloudlogs to incorporate client.ip as it was missing and is required by definition of the
    ingest pipeline.
  4. Added edge test case to support IPV6 parsing check and failures for sub-packages : activitylogs, 'auditlogs', 'platformlogs' & 'springcloudlogs'

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • All tests should pass in azure activitylogs, auditlogs, platformlogs & springcloudlogs modules , including newly added edge cases IPV6 scenario

How to test this PR locally

Use elastic package to test locally by running command - elastic-package test from inside packages/azure directory

Related issues

Shourie Ganguly and others added 2 commits May 23, 2022 15:50
…h convert. Added edge test case to support IPV6 parsing check
…h convert. Added edge test case to support IPV6 parsing check
@ShourieG
ShourieG requested a review from a team as a code owner May 23, 2022 12:42
@cla-checker-service

cla-checker-service Bot commented May 23, 2022

Copy link
Copy Markdown

💚 CLA has been signed

@elasticmachine

elasticmachine commented May 23, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-26T05:08:59.789+0000

  • Duration: 14 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 89
Skipped 0
Total 89

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented May 23, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 78.571% (11/14) 👎 -17.857
Classes 78.571% (11/14) 👎 -17.857
Methods 77.876% (88/113) 👎 -11.226
Lines 81.516% (1570/1926) 👎 -8.969
Conditionals 100.0% (0/0) 💚
@ShourieG ShourieG closed this May 23, 2022
@ShourieG ShourieG reopened this May 23, 2022
@ShourieG ShourieG closed this May 23, 2022
@ShourieG ShourieG reopened this May 23, 2022
@ShourieG
ShourieG requested review from a team and adriansr May 23, 2022 13:56
@ShourieG ShourieG changed the title bug/azure-issues-2138-fix May 23, 2022
@ShourieG ShourieG changed the title [Azure] - bug fix for issue #2138 , replaced grok filter with convert May 23, 2022
Comment thread packages/azure/changelog.yml Outdated
Comment thread packages/azure/data_stream/activitylogs/elasticsearch/ingest_pipeline/default.yml Outdated
@adriansr

Copy link
Copy Markdown
Contributor

In order to reference an issue or PR, instead of azure-issues-2138, use the #NNNN format if the issue belongs to the current repo, or a link if it belongs to a different repo. This way it can be accessed quickly

@ShourieG ShourieG changed the title [Azure] Bug fix for issue #2138 , replaced grok filter with convert May 24, 2022
…formlogs' & 'springcloudlogs' , added edge-case and faliure senario test cases
Comment thread packages/azure/data_stream/activitylogs/elasticsearch/ingest_pipeline/default.yml Outdated

@r00tu53r r00tu53r left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adriansr adriansr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ShourieG
ShourieG requested a review from efd6 May 25, 2022 10:31

@kaiyan-sheng kaiyan-sheng left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just one nit: since we are not using the grok to parse anymore, should source.port field be removed from ecs.yml file?

@ShourieG
ShourieG merged commit 4317807 into elastic:main May 26, 2022
@ShourieG
ShourieG deleted the bug/azure-issues-2138-fix branch November 9, 2022 06:14
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
…stic#3411)

* added bug fix for issue 'azure-issues-2138' replacing grok filter with convert. Added edge test case to support IPV6 parsing check

* added bug fix for issue 'azure-issues-2138' replacing grok filter with convert. Added edge test case to support IPV6 parsing check

* Added change logs and upgraded azure minor version from 1.1.8 -> 1.1.9

* updated change logs and added trailing lines

* removed trailing lines from  test files for test-activitylogs-edgecases

* [Azure] Improved IPv6 handling for 'activitylogs', 'auditlogs', 'platformlogs' & 'springcloudlogs' , added edge-case and faliure senario test cases

* removed extra spaces from rename processors

* removed source.port from ecs.yml of 'activitylogs', 'auditlogs', 'platformlogs' & 'springcloudlogs'.

Co-authored-by: Shourie Ganguly <exdghost@Shouries-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants