Skip to content

[cisco] Fix Cisco AMP rate limit reset time. - #3558

Merged
marc-gr merged 5 commits into
elastic:mainfrom
marc-gr:fix-cisco-amp
Jul 11, 2022
Merged

[cisco] Fix Cisco AMP rate limit reset time.#3558
marc-gr merged 5 commits into
elastic:mainfrom
marc-gr:fix-cisco-amp

Conversation

@marc-gr

@marc-gr marc-gr commented Jun 22, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

The module was not able to honor the rate limit reset times, this fixes the issue.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@marc-gr marc-gr added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cisco_secure_endpoint Cisco Secure Endpoint labels Jun 22, 2022
@marc-gr
marc-gr requested a review from a team as a code owner June 22, 2022 08:46
@elasticmachine

elasticmachine commented Jun 22, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine

elasticmachine commented Jun 22, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-11T10:08:24.607+0000

  • Duration: 15 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jun 22, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.158
Classes 100.0% (1/1) 💚 3.158
Methods 93.333% (14/15) 👍 3.805
Lines 89.173% (453/508) 👎 -1.876
Conditionals 100.0% (0/0) 💚
andrewkroh
andrewkroh reviewed Jun 23, 2022
View reviewed changes
Comment thread packages/cisco_secure_endpoint/data_stream/event/agent/stream/httpjson.yml.hbs Outdated
@marc-gr
marc-gr requested a review from andrewkroh June 23, 2022 13:06
@marc-gr
marc-gr merged commit 5c58b60 into elastic:main Jul 11, 2022
@marc-gr
marc-gr deleted the fix-cisco-amp branch July 11, 2022 10:34
@andrewkroh andrewkroh mentioned this pull request Jul 13, 2022
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@marc-gr
[cisco] Fix Cisco AMP rate limit reset time. (elastic#3558)
23a384f 
* Fix Cisco AMP rate limit reset time.

* Add pr number

* Update changelog.yml

* Fix RateLimit header names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:cisco_secure_endpoint Cisco Secure Endpoint

4 participants

@marc-gr @elasticmachine @andrewkroh @efd6