Skip to content

Fix GCP auditlog parsing issue on response status - #3583

Merged
kcreddy merged 3 commits into
elastic:mainfrom
kcreddy:gcp_audit_response_status_parsing
Jun 27, 2022
Merged

Fix GCP auditlog parsing issue on response status#3583
kcreddy merged 3 commits into
elastic:mainfrom
kcreddy:gcp_audit_response_status_parsing

Conversation

@kcreddy

@kcreddy kcreddy commented Jun 24, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Updates the package names with standard wording

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@kcreddy kcreddy added bug Something isn't working, use only for issues Team:Security-External Integrations labels Jun 24, 2022
@kcreddy
kcreddy requested a review from P1llus June 24, 2022 10:08
@kcreddy
kcreddy marked this pull request as ready for review June 24, 2022 10:08
@kcreddy
kcreddy requested review from a team as code owners June 24, 2022 10:08
@elasticmachine

elasticmachine commented Jun 24, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine

elasticmachine commented Jun 24, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-27T06:13:09.597+0000

  • Duration: 20 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jun 24, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 3.555
Classes 100.0% (4/4) 💚 3.555
Methods 98.246% (56/57) 👍 8.933
Lines 95.969% (1119/1166) 👍 5.133
Conditionals 100.0% (0/0) 💚
P1llus
P1llus approved these changes Jun 27, 2022
View reviewed changes

@P1llus P1llus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kcreddy
kcreddy merged commit 07acca6 into elastic:main Jun 27, 2022
@andrewkroh andrewkroh mentioned this pull request Jun 27, 2022
Merged
@kcreddy
kcreddy deleted the gcp_audit_response_status_parsing branch June 28, 2022 05:18
@kcreddy kcreddy mentioned this pull request Nov 8, 2023
Closed
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@kcreddy
Fix GCP auditlog parsing issue on response status (elastic#3583)
41c8d42 
* add status_value if response status is not object

* add changelog

* remove ignore_failure and add ignore_missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues

3 participants

@kcreddy @elasticmachine @P1llus