Skip to content

gcp: remove gcp.audit.* fields duplicated in ECS fields - #3609

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:3397-gcp
Jul 21, 2022
Merged

gcp: remove gcp.audit.* fields duplicated in ECS fields#3609
efd6 merged 1 commit into
elastic:mainfrom
efd6:3397-gcp

Conversation

@efd6

@efd6 efd6 commented Jun 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This resolves a set of TODOs by removing duplicated fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:gcp Google Cloud Platform labels Jun 28, 2022
@efd6
efd6 requested a review from r00tu53r June 28, 2022 03:05
@efd6 efd6 self-assigned this Jun 28, 2022
@efd6
efd6 requested review from a team as code owners June 28, 2022 03:05
@elasticmachine

elasticmachine commented Jun 28, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine

elasticmachine commented Jun 28, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-20T22:56:37.308+0000

  • Duration: 32 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 46
Skipped 0
Total 46

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jun 28, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 93.939% (62/66) ❕
Lines 95.21% (1113/1169) ❕
Conditionals 100.0% (0/0) 💚
@andrewkroh

andrewkroh commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

@r00tu53r Can you please take a look as this appears related to an earlier change of yours.
r00tu53r
r00tu53r approved these changes Jul 21, 2022
View reviewed changes

@r00tu53r r00tu53r left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efd6 thank you for addressing the TODOs. LGTM.
@efd6
efd6 merged commit 0c91e64 into elastic:main Jul 21, 2022
@andrewkroh andrewkroh mentioned this pull request Jul 26, 2022
Merged
@efd6
efd6 deleted the 3397-gcp branch February 5, 2025 22:07
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
gcp: remove gcp.audit.* fields duplicated in ECS fields (elastic#3609)
7657455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:gcp Google Cloud Platform

4 participants

@efd6 @elasticmachine @andrewkroh @r00tu53r