Skip to content

Redis enterprise Integration- Beta package - #3617

Merged
lalit-satapathy merged 12 commits into
elastic:mainfrom
lalit-satapathy:redis-enterprise-ver1
Jul 12, 2022
Merged

Redis enterprise Integration- Beta package#3617
lalit-satapathy merged 12 commits into
elastic:mainfrom
lalit-satapathy:redis-enterprise-ver1

Conversation

@lalit-satapathy

@lalit-satapathy lalit-satapathy commented Jun 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Redis Enterprise Integration beta release. Closes #3457

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Pending Items

How to test this PR locally

  • Docker install redislabs/redis:5.2.2-24
  • Create a dummy node and database
  • Ensure that the prometheus port (8070) is exported
  • Pass the host:8070 to the integration hosts

Related issues

Screenshots

redisenterprise-dashboard
@lalit-satapathy lalit-satapathy added enhancement New feature or request Team:Service-Integrations Label for the Observability Service Integrations team 8.4 candidate labels Jun 29, 2022
@lalit-satapathy
lalit-satapathy requested a review from a team June 29, 2022 05:49
@lalit-satapathy lalit-satapathy self-assigned this Jun 29, 2022
@elasticmachine

elasticmachine commented Jun 29, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-12T07:38:38.053+0000

  • Duration: 15 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jun 29, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.145
Classes 100.0% (0/0) 💚 3.145
Methods 50.0% (4/8) 👎 -39.567
Lines 100.0% (0/0) 💚 8.936
Conditionals 100.0% (0/0) 💚
muthu-mps
muthu-mps reviewed Jun 30, 2022
View reviewed changes

@muthu-mps muthu-mps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metric names which appears inside the visualisation can be removed. Like system, user, Free Memory which is already part of the title.
@muthu-mps
muthu-mps self-requested a review June 30, 2022 04:45
muthu-mps
muthu-mps reviewed Jun 30, 2022
View reviewed changes
Comment thread packages/redisenterprise/data_stream/node/elasticsearch/ingest_pipeline/default.yml Outdated
ishleenk17
ishleenk17 reviewed Jun 30, 2022
View reviewed changes
Comment thread packages/redisenterprise/manifest.yml Outdated
ishleenk17
ishleenk17 reviewed Jul 4, 2022
View reviewed changes
Comment thread packages/redisenterprise/data_stream/node/sample_event.json Outdated
Comment thread packages/redisenterprise/data_stream/node/fields/fields.yml Outdated
Comment thread packages/redisenterprise/data_stream/proxy/sample_event.json
Comment thread ...s/redisenterprise/kibana/dashboard/redisenterprise-8da53a40-5a2f-11ea-bc69-cdcc68092a57.json
Comment thread packages/redisenterprise/data_stream/proxy/fields/fields.yml Outdated
@lalit-satapathy
Dashboard by value.
26f5e1f 
Remove node_ from redisenterprise.node.
Update sample event.
Other minor changes.
@lalit-satapathy
updated image.
efe230b
@lalit-satapathy
ecs.verion.
7d7430d
@lalit-satapathy
lalit-satapathy marked this pull request as ready for review July 6, 2022 06:02
@lalit-satapathy

lalit-satapathy commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

The metric names which appears inside the visualisation can be removed. Like system, user, Free Memory which is already part of the title.

Making it empty causes some issue, so we need some description there.
ishleenk17
ishleenk17 reviewed Jul 8, 2022
View reviewed changes
Comment thread packages/redisenterprise/_dev/build/docs/README.md
ishleenk17
ishleenk17 reviewed Jul 12, 2022
View reviewed changes
Comment thread packages/redisenterprise/data_stream/proxy/sample_event.json Outdated
@muthu-mps
muthu-mps self-requested a review July 12, 2022 10:52
muthu-mps
muthu-mps approved these changes Jul 12, 2022
View reviewed changes

@muthu-mps muthu-mps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@lalit-satapathy
lalit-satapathy merged commit f3234e8 into elastic:main Jul 12, 2022
@andrewkroh andrewkroh added Integration:redisenterprise Redis Enterprise New Integration Issue or pull request for creating a new integration package. labels Aug 13, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@lalit-satapathy
Redis enterprise Integration- Beta package (elastic#3617)
0495f21 
* Redis enterprise integration beta tested with 5.2 version.
* Uses prometheus end-point to export the metrics.
* Initial dashboards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.4 candidate enhancement New feature or request Integration:redisenterprise Redis Enterprise New Integration Issue or pull request for creating a new integration package. Team:Service-Integrations Label for the Observability Service Integrations team

5 participants

@lalit-satapathy @elasticmachine @muthu-mps @ishleenk17 @andrewkroh